Date: Fri, 18 Dec 2009 15:38:34 -0800 From: Doug Barton <dougb@FreeBSD.org> To: =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= <des@des.no> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Warner Losh <imp@freebsd.org>, John Baldwin <jhb@freebsd.org> Subject: Re: svn commit: r200606 - in head/sys: compat/freebsd32 sys Message-ID: <4B2C127A.8060509@FreeBSD.org> In-Reply-To: <868wd0cyjd.fsf@ds4.des.no> References: <200912161717.nBGHHeQZ005541@svn.freebsd.org> <200912161541.53834.jhb@freebsd.org> <868wd0cyjd.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
Dag-Erling Smørgrav wrote: > John Baldwin <jhb@freebsd.org> writes: >> Warner Losh <imp@freebsd.org> writes: >>> Log: >>> Fix compiling FREEBSD_COMPAT[4,5,6] without FREEBSD_COMPAT7. >>> >>> Note: Not sure this is the right way to do compat, but it makes the >>> headers consistent with the implementations. >> Please revert. I think this has already been reverted once before. > > Yep, that was me... we concluded back then that this is a perfectly > reasonable dependency; perhaps we should simply add the appropriate > #ifndef / #error constructs so you can't define FREEBSD_COMPAT(n) > without FREEBSD_COMPAT(n+1). Trying to look at this from the user perspective, it's kind of silly that if what I want is COMPAT5 I also need to add COMPAT<somethingelse>. I don't know the issues in the code so I don't know what the solution should be on the back end, but on the front end what needs to work is that I specify the compat level I want in my kernel config, then the code does what's necessary to make that work. Doug -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B2C127A.8060509>