Date: Thu, 30 Jun 2016 13:19:18 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Bryan Drewery <bdrewery@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r417364 - head/Mk/Scripts Message-ID: <20160630111918.nhilkb4xgrgqwlde@ivaldir.etoilebsd.net> In-Reply-To: <685BD37565065F0C493733CE@atuin.in.mat.cc> References: <201606231131.u5NBVFur021580@repo.freebsd.org> <075ef3c9-89f1-8e95-c86a-bf00831c373e@FreeBSD.org> <20160630054109.beqlksn3juwodf72@ivaldir.etoilebsd.net> <685BD37565065F0C493733CE@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
--7pl3dz4woquv2nwa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 30, 2016 at 10:21:03AM +0200, Mathieu Arnold wrote: >=20 >=20 > +--On 30 juin 2016 07:41:09 +0200 Baptiste Daroussin <bapt@FreeBSD.org> > wrote: > | On Wed, Jun 29, 2016 at 04:33:52PM -0700, Bryan Drewery wrote: > |> On 6/23/2016 4:31 AM, Mathieu Arnold wrote: > |> > Author: mat > |> > Date: Thu Jun 23 11:31:15 2016 > |> > New Revision: 417364 > |> > URL: https://svnweb.freebsd.org/changeset/ports/417364 > |> >=20 > |> > Log: > |> > Extend the symlink checks to warn on absolute targets. > |> > =20 > |> > Sponsored by: Absolight > |> > Differential Revision: https://reviews.freebsd.org/D6930 > |>=20 > |> Why? This seems like noise. > |=20 > | Quite true as it is I overlooked it. > |=20 > | To ease relocatable packages (to prepare sysroot for exemple) symlinks > | that points to file within the same package should be absolute links. > |=20 > | After looking at this patch again I think it should be reverted and > | replaced later by something that will check symlinks on the same plist >=20 > Mmmm, I can add a check to see if the target is in STAGEDIR and only emit > the warning if it is. would definitly help Bapt --7pl3dz4woquv2nwa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXdQA2AAoJEGOJi9zxtz5aY5gP/15DVsc5w2B7MTdfCQy6XonH pK/8RjrXrwt6q25WeMo87inR5+JTKajoKvKvDnin3cqLMgulLtcfh1B3Mygo2nig KD47A8KFCsJk5DipLoVC8tT3l7u0SlOa3xEe8R377QSXm12gW6VqGn32BkpGH8K2 FdHBU6CG32veK2b82KqOTsaJ5ArbBMZVkiNwrCIITtmaFgYqqAkqwh/etpVsroZU U9TkYUcAtyR/O++BxKiM3xfzB4uxnJOeclXaUTeGuV3cLhmGbC1KD3xTOhLw8M0n H/+HX7vGuuvZNVN3DI8WlWotL4cLV9Cy2SM6oNOqqDguTiHW+SPQwBaKbfvmXBjB cm3ET8k+09ykXwDsvWS6YGsblqTTRIQg7QXYDS/bCpksbGSNlpcYIRQKV8dfpFzj 5wG+7ap9FRAwLwrZ13Wic5u/CXYZBviP7J7eWSfgWKKp+5ZCNw3F7WXo7AIWOU1t oszGD17FjWQOO08ufmHwsfYjMb+mUPveMq5/C9/pXhu9k52w8jhg4WjrGzxoE28I pz8iwhTnRM6wgm3NkwckBOmiECvohClyEhT4T7lkiv5YQ6BclKbQfMmnhVR4kwkc QoHaNt+gYgfQVTYytsh7dusZrfJKytAMBKlb3MmOT9MLHoVVukjAMUzHCbyra2Z3 tH/anurkB19p7BaKBwBZ =9y4T -----END PGP SIGNATURE----- --7pl3dz4woquv2nwa--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160630111918.nhilkb4xgrgqwlde>