Date: Tue, 23 Mar 2021 03:15:47 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 159356] [zfs] [patch] ZFS NAME_ERR_DISKLIKE check is Solaris-specific Message-ID: <bug-159356-227-5dnymJ8ASq@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-159356-227@https.bugs.freebsd.org/bugzilla/> References: <bug-159356-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D159356 Dennis Clarke <dclarke@blastwave.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dclarke@blastwave.org --- Comment #3 from Dennis Clarke <dclarke@blastwave.org> --- This is still a concern with OpenZFS in that: sys/contrib/openzfs/module/zcommon/zfs_namecheck.c=20=20 still looks like :=20 453 if (pool[0] =3D=3D 'c' && (pool[1] >=3D '0' && pool[1] <=3D= '9')) { 454 if (why) 455 *why =3D NAME_ERR_DISKLIKE; 456 return (-1); 457 } Surely this can be changed to looking for ada0 or even da0 type stuff? --=20 Dennis Clarke RISC-V/SPARC/PPC/ARM/CISC UNIX and Linux spoken GreyBeard and suspenders optional --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-159356-227-5dnymJ8ASq>