Date: Thu, 23 Mar 2017 22:21:51 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= <des@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r315850 - head/sys/boot/forth Message-ID: <20170323205948.N2588@besplex.bde.org> In-Reply-To: <201703230834.v2N8YVDA003255@repo.freebsd.org> References: <201703230834.v2N8YVDA003255@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 23 Mar 2017, [UTF-8] Dag-Erling Sm=C3=B8rgrav wrote: > Log: > The original author abused Nd (one-line description, used by makewhatis) > for its side effect of producing an en-dash. This broke whatis with > newer versions of mdocml. Use \(en instead. Nd (or is it mumble-dash?) is broken for all man pages. Old man renders the dash for Nd as 2 hyphens in ascii. New man renders it as 1 hyphen in ascii. postscript output is even more broken. Old man renders the dash for Nd as an especially wide one. New man still seems to render it as 1 hyphen, and hyphens are especially narrow in postscript output for new man (they are 1.5 to 2 times narrower than with old man, and that is with a larger font for the smaller hyphens). Altogther, the dash for Nd is about 4 times larger with old man after adjusting for the font size (about 3 average characters wide instead of 3/4). Whatever the dash for Nd is, it shouldn't look like a hyphen. I compared the output of "man ls.1 | col -bx". The diffs were too large due to different policies for splitting lines, but this and 2 other known bugs were obvious (the others are sentence breaks after complicated sentenc= e terminations like ".)", and -width not working giving misformatted tables and lists). Different justification was even more obvious. -Tascii uses hyphens to split long lines with old man only, and this allows perfect right justification in postscript output for old man only. New man apparently doesn't try to right justify for -Tps any more than with -Tascii= =2E Bruce From owner-svn-src-head@freebsd.org Thu Mar 23 11:59:18 2017 Return-Path: <owner-svn-src-head@freebsd.org> Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D61FAD1AA0D; Thu, 23 Mar 2017 11:59:18 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9ACC0CCF; Thu, 23 Mar 2017 11:59:18 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v2NBxHnw085167; Thu, 23 Mar 2017 11:59:17 GMT (envelope-from avg@FreeBSD.org) Received: (from avg@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id v2NBxHLf085166; Thu, 23 Mar 2017 11:59:17 GMT (envelope-from avg@FreeBSD.org) Message-Id: <201703231159.v2NBxHLf085166@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: avg set sender to avg@FreeBSD.org using -f From: Andriy Gapon <avg@FreeBSD.org> Date: Thu, 23 Mar 2017 11:59:17 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r315858 - head/sys/dev/aacraid X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current <svn-src-head.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>, <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>; List-Post: <mailto:svn-src-head@freebsd.org> List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>, <mailto:svn-src-head-request@freebsd.org?subject=subscribe> X-List-Received-Date: Thu, 23 Mar 2017 11:59:18 -0000 Author: avg Date: Thu Mar 23 11:59:17 2017 New Revision: 315858 URL: https://svnweb.freebsd.org/changeset/base/315858 Log: aacraid: rework r315083 for a clean build with and without AACRAID_DEBUG r315083 essentially reverted r263954 which was made for a good reason, but didn't take into account AACRAID_DEBUG. Now both types of build should be clean. MFC after: 5 days No MFC to: stable/10 Modified: head/sys/dev/aacraid/aacraid_cam.c Modified: head/sys/dev/aacraid/aacraid_cam.c ============================================================================== --- head/sys/dev/aacraid/aacraid_cam.c Thu Mar 23 10:50:45 2017 (r315857) +++ head/sys/dev/aacraid/aacraid_cam.c Thu Mar 23 11:59:17 2017 (r315858) @@ -243,13 +243,11 @@ static int aac_cam_probe(device_t dev) { struct aac_cam *camsc; - struct aac_softc *sc; camsc = (struct aac_cam *)device_get_softc(dev); if (!camsc->inf) return (0); - sc = camsc->inf->aac_sc; - fwprintf(sc, HBA_FLAGS_DBG_FUNCTION_ENTRY_B, ""); + fwprintf(camsc->inf->aac_sc, HBA_FLAGS_DBG_FUNCTION_ENTRY_B, ""); return (0); } @@ -1136,11 +1134,9 @@ static void aac_container_complete(struct aac_command *cm) { union ccb *ccb; - struct aac_softc *sc; u_int32_t status; - sc = cm->cm_sc; - fwprintf(sc, HBA_FLAGS_DBG_FUNCTION_ENTRY_B, ""); + fwprintf(cm->cm_sc, HBA_FLAGS_DBG_FUNCTION_ENTRY_B, ""); ccb = cm->cm_ccb; status = ((u_int32_t *)cm->cm_fib->data)[0];
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170323205948.N2588>