Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 02 Apr 2026 10:24:41 +0000
From:      Andrey V. Elsukov <ae@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: d9d7b5948649 - main - ipfw_nptv6: fix handling the ifaddr removal event
Message-ID:  <69ce43e9.3fb11.185578c2@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by ae:

URL: https://cgit.FreeBSD.org/src/commit/?id=d9d7b59486499615a5fdce54443ce62aecf557e8

commit d9d7b59486499615a5fdce54443ce62aecf557e8
Author:     Andrey V. Elsukov <ae@FreeBSD.org>
AuthorDate: 2026-04-02 10:14:29 +0000
Commit:     Andrey V. Elsukov <ae@FreeBSD.org>
CommitDate: 2026-04-02 10:14:29 +0000

    ipfw_nptv6: fix handling the ifaddr removal event
    
    The result of IN6_ARE_MASKED_ADDR_EQUAL() macro is not an integer, so
    threat it as a boolean value.
    
    PR:             294114
    Reported by:    Peter Much <pmc citylink dinoex sub org>
    MFC after:      1 week
---
 sys/netpfil/ipfw/nptv6/nptv6.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/netpfil/ipfw/nptv6/nptv6.c b/sys/netpfil/ipfw/nptv6/nptv6.c
index bfe28d75a01d..c36e9597fe22 100644
--- a/sys/netpfil/ipfw/nptv6/nptv6.c
+++ b/sys/netpfil/ipfw/nptv6/nptv6.c
@@ -593,8 +593,8 @@ ifaddr_cb(struct namedobj_instance *ni, struct named_object *no,
 		if ((cfg->flags & NPTV6_READY) == 0)
 			return (0);
 		/* If address does not match the external prefix, ignore */
-		if (IN6_ARE_MASKED_ADDR_EQUAL(&cfg->external, args->addr,
-		    &cfg->mask) != 0)
+		if (!IN6_ARE_MASKED_ADDR_EQUAL(&cfg->external, args->addr,
+		    &cfg->mask))
 			return (0);
 		/* Otherwise clear READY flag */
 		cfg->flags &= ~NPTV6_READY;


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69ce43e9.3fb11.185578c2>