Date: Thu, 13 Jun 2013 17:50:56 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Jeff Roberson <jeff@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r251703 - in head/sys: amd64/amd64 i386/i386 i386/xen kern mips/mips sparc64/sparc64 sys Message-ID: <51BA4CD0.30601@FreeBSD.org> In-Reply-To: <201306132046.r5DKk3xd006430@svn.freebsd.org> References: <201306132046.r5DKk3xd006430@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2HPVKJFDPJSPQJBRPXIQN Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 6/13/2013 3:46 PM, Jeff Roberson wrote: > Author: jeff > Date: Thu Jun 13 20:46:03 2013 > New Revision: 251703 > URL: http://svnweb.freebsd.org/changeset/base/251703 >=20 > Log: > - Add a BIT_FFS() macro and use it to replace cpusetffs_obj() > =20 > Discussed with: attilio > Sponsored by: EMC / Isilon Storage Division >=20 > Modified: > head/sys/amd64/amd64/mp_machdep.c > head/sys/i386/i386/mp_machdep.c > head/sys/i386/i386/pmap.c > head/sys/i386/xen/mp_machdep.c > head/sys/i386/xen/pmap.c > head/sys/kern/kern_cpuset.c > head/sys/mips/mips/mp_machdep.c > head/sys/sparc64/sparc64/mp_machdep.c > head/sys/sys/bitset.h > head/sys/sys/cpuset.h >=20 [...] > Modified: head/sys/sys/cpuset.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/sys/cpuset.h Thu Jun 13 20:41:09 2013 (r251702) > +++ head/sys/sys/cpuset.h Thu Jun 13 20:46:03 2013 (r251703) > @@ -57,6 +57,7 @@ > #define CPU_SET_ATOMIC(n, p) BIT_SET_ATOMIC(CPU_SETSIZE, n, p) > #define CPU_OR_ATOMIC(d, s) BIT_OR_ATOMIC(CPU_SETSIZE, d, s) > #define CPU_COPY_STORE_REL(f, t) BIT_COPY_STORE_REL(CPU_SETSIZE, f, t)= > +#define CPU_FFS(p) BIT_FFS(CPU_SETSIZE, p) > =20 > /* > * Valid cpulevel_t values. > @@ -118,7 +119,6 @@ void cpuset_rel(struct cpuset *); > int cpuset_setthread(lwpid_t id, cpuset_t *); > int cpuset_create_root(struct prison *, struct cpuset **); > int cpuset_setproc_update_set(struct proc *, struct cpuset *); > -int cpusetobj_ffs(const cpuset_t *); > char *cpusetobj_strprint(char *, const cpuset_t *); > int cpusetobj_strscan(cpuset_t *, const char *); > =20 Looks like cpusetobj_ffs() -> CPU_FFS() was missed in sys/amd64/vmm/io/vlapic.c: > --- vlapic.o --- > /usr/src/sys/modules/vmm/../../amd64/vmm/io/vlapic.c:468:15: error: imp= licit declaration of function 'cpusetobj_ffs' is invalid in C99 [-Werror,= -Wimplicit-function-declaration] > while ((i =3D cpusetobj_ffs(&dmask)) !=3D 0) { --=20 Regards, Bryan Drewery ------enig2HPVKJFDPJSPQJBRPXIQN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRukzVAAoJEG54KsA8mwz5BIQP/i7A0Pjw8wD7RcbeEVF0Cci/ i7x86FMI/1k7fPpPdQEQrgrPfUlo36sgqMPuxJdq/uAtFkbHTFk5EFACi5wXKPcL kch+a/Zu+RUgw0uLhrbMMzQMUIcUVD7rPGVmhfcFdOgrp5J7K4QhA1beWA27PpKm nmzE9JGI/XKUhtbcYtqQjDnwFgs1FUsw6XMKAGiPmi4jzCtIr+WNwpphOD3iSP8D 2Y4+O9CqTRkbsHsCMnSPM2aQiyG3O44uRo7wega3KldbRjY1lfUhQPaiq5ukVShb qnZEU84rTCUUCQaFOz7kdXb0WxvdM3TO1SFVl50ICxtWVde2ykyB3gA3fhNCdKoW P5sfRytw+Y424wG1CBvcFL24EVva5bQxdk7OzJQyRWZIDVMEWtNajCArNkazJ/C8 T2w/dV8mkiAmY9h0dXnPDHEm4s66tnZ9uVXcY4kmLOnMtQAlwdXbbaxVokyzScQw VNpgZ1IRJFGmjXMHJTxKbaKLKujnN28zPKyYJ1QhUki6mUb7goK/PSzywryMJTtI 2aio9+jzMwwKyFxUxLARiXFnPxgevqv2ZU+hG7c7L+jFicD7gL2SZovvVfdH5RIr NwsVyS2Mfe/V1hDr6nWETbz5oWN25S8qaK1Ar2lsaYG+wxtcJ7ACxy2eXkqyIKKU I/+pjAvj/6ei/d0jFSX3 =0QAD -----END PGP SIGNATURE----- ------enig2HPVKJFDPJSPQJBRPXIQN--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51BA4CD0.30601>