Date: Wed, 30 Nov 2016 22:04:19 +0000 From: "hselasky (Hans Petter Selasky)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] D8685: Fix a false positive in a buf_ring assert Message-ID: <c5cef132307e0f318d36e3b2367efa95@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-7bpwu3y3lzsbz4zoj3jc-req@FreeBSD.org> References: <differential-rev-PHID-DREV-7bpwu3y3lzsbz4zoj3jc-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
hselasky added inline comments.
INLINE COMMENTS
> buf_ring.h:71
> + if (br->br_cons_head != br->br_prod_head) {
> + for (i = br->br_cons_head + 1; i != br->br_prod_head;
> + i = ((i + 1) & br->br_cons_mask))
should "br->br_cons_head + 1" be masked by br->br_cons_mask ??
REVISION DETAIL
https://reviews.freebsd.org/D8685
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: rstone
Cc: hselasky, freebsd-net-list, emaste
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c5cef132307e0f318d36e3b2367efa95>