Date: Tue, 3 Jun 2008 12:38:00 +0000 (UTC) From: Ed Schouten <ed@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern tty_tty.c Message-ID: <200806031238.m53CcIVv039608@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
ed 2008-06-03 12:38:18 UTC
FreeBSD src repository
Modified files:
sys/kern tty_tty.c
Log:
SVN rev 179519 on 2008-06-03 12:38:00Z by ed
Remove unneeded Giant locking of /dev/tty.
The Giant lock is acquired in two places in tty_tty.c. In both places,
it is unneeded.
There is no reason to specify D_NEEDGIANT on this device node. The
device node has only been designed to return ENXIO when opened. It
doesn't make any sense to lock/unlock Giant, just to return this error.
D_TTY is also unneeded. The unimplemented functions don't need to be
patched by devfs.
We don't need to lock Giant when we want to lookup the proper TTY vnode.
s_ttyvp is already protected by proctree_lock (see devfs_vnops.c).
Approved by: philip (mentor)
Revision Changes Path
1.62 +0 -3 src/sys/kern/tty_tty.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200806031238.m53CcIVv039608>