Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 30 Sep 2025 10:39:27 -0700
From:      Gleb Smirnoff <glebius@freebsd.org>
To:        Kristof Provost <kp@freebsd.org>, ItzBlinkzy <kitey13579@gmail.com>, Kevin Irabor <kevin.irabor04@gmail.com>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 4e7a375804e5 - main - IfAPI: Added missing accessor for if_home_vnet
Message-ID:  <aNwVz6wL5cLbmYqR@cell.glebi.us>
In-Reply-To: <202509292116.58TLGxWx078766@gitrepo.freebsd.org>
References:  <202509292116.58TLGxWx078766@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
  Hi,

On Mon, Sep 29, 2025 at 09:16:59PM +0000, Kristof Provost wrote:
K> URL: https://cgit.FreeBSD.org/src/commit/?id=4e7a375804e5ad4b244ce9a035fa971cbf2f0944
K> 
K> commit 4e7a375804e5ad4b244ce9a035fa971cbf2f0944
K> Author:     ItzBlinkzy <kitey13579@gmail.com>
K> AuthorDate: 2025-09-28 17:21:41 +0000
K> Commit:     Kristof Provost <kp@FreeBSD.org>
K> CommitDate: 2025-09-29 21:15:55 +0000
K> 
K>     IfAPI: Added missing accessor for if_home_vnet
K>     
K>     Reviewed by:    kp
K>     Signed-off-by:  Kevin Irabor <kevin.irabor04@gmail.com>

So, who is the actual author of the patch kitey13579@gmail.com or
<kevin.irabor04@gmail.com>?

The actual question is whether there is a driver that really needs to access
this field or was this added by the logic that if a field exists in struct
ifnet, a function to access it shall exist?

-- 
Gleb Smirnoff



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aNwVz6wL5cLbmYqR>