Date: Wed, 17 Nov 2021 03:53:29 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Yasuhiro Kimura <yasu@utahime.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: bb8dbe1580ae - main - sysutils/lnav: Fix distinfo Message-ID: <YZR8uQqrn0fCeKLH@FreeBSD.org> In-Reply-To: <20211117.124452.1254944101155682425.yasu@utahime.org> References: <202111170314.1AH3ETSV087319@gitrepo.freebsd.org> <YZR1/8m59hCb41l1@FreeBSD.org> <20211117.124452.1254944101155682425.yasu@utahime.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 17, 2021 at 12:44:52PM +0900, Yasuhiro Kimura wrote: > From: Alexey Dokuchaev <danfe@freebsd.org> > Subject: Re: git: bb8dbe1580ae - main - sysutils/lnav: Fix distinfo > Date: Wed, 17 Nov 2021 03:24:47 +0000 > > > I know you prefer DISTVERSION by default for some obscure reason, but > > changing just the knob spelling without actual version number is what > > we call gratuitous change and something we try to avoid as it clobbers > > the history, thus pessimizing code archaeology process, and decreases > > commit diff SNR. > > It's not just my personal preference. Section of 5.2.2 of Porter's > Handbook says as following. Yeah, I know, and I don't buy this reasoning, but that's not the point, the point is gratuitous changes and "fixing" what ain't broken. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YZR8uQqrn0fCeKLH>