Date: Thu, 7 Dec 2023 15:24:35 -0800 From: "Simon J. Gerraty" <sjg@juniper.net> To: Warner Losh <imp@bsdimp.com> Cc: Jessica Clarke <jrtc27@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org>, <sjg@juniper.net> Subject: Re: git: 83d0b8c089d8 - main - bsdinstall generate opt_osname.h in include Message-ID: <43001.1701991475@kaos.jnpr.net> In-Reply-To: <CANCZdfoK4V_r_3qVgKJLPMxweTyXyPLFrHHJqTXRomE=woqSRQ@mail.gmail.com> References: <202312070235.3B72ZoZp043061@gitrepo.freebsd.org> <CANCZdfpm=GD5_5tf3LCrhVWcv95jb86mj23JEAX=2dsKyJQ5rQ@mail.gmail.com> <71239.1701921562@kaos.jnpr.net> <D51E0060-60C3-4D56-96C5-B51F1D07DD6C@freebsd.org> <58331.1701924865@kaos.jnpr.net> <CANCZdfoK4V_r_3qVgKJLPMxweTyXyPLFrHHJqTXRomE=woqSRQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Warner Losh <imp@bsdimp.com> wrote: > > > The reason I did it using a file is so that make(1) would detect a > > > change a rebuild if you change the value and do another build. > > A fair point. Of course moot if using META_MODE. > The other benefit of the header is only the files that include it will > be rebuilt when the value changes whereas (with META_MODE) everything > will be rebuilt if value is in CFLAGS. > > That can be mitigated by using per object CFLAGS, but all in all the > header is a simpler solution. > > This name never changes on practice. We shouldn't optimize for a rare > case that causes build races. Who would ever change it in the same > tree? Also a fair point. I'm happy to do it either way - so long as we avoid circular dependencies.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?43001.1701991475>