Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 14 Jul 2002 09:58:40 -0700
From:      Luigi Rizzo <luigi@FreeBSD.org>
To:        Mark Peek <mp@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/release/picobsd/build write_mfs_in_kernel.c
Message-ID:  <20020714095839.H74633@iguana.icir.org>
In-Reply-To: <p05111a0db9575adde9d7@[10.1.1.73]>; from mp@FreeBSD.org on Sun, Jul 14, 2002 at 09:50:05AM -0700
References:  <200207141209.g6EC9XBL099971@freefall.freebsd.org> <p05111a0bb95747d37370@[10.1.1.73]> <20020714093834.E74633@iguana.icir.org> <p05111a0db9575adde9d7@[10.1.1.73]>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jul 14, 2002 at 09:50:05AM -0700, Mark Peek wrote:
> At 9:38 AM -0700 7/14/02, Luigi Rizzo wrote:
> >i guess that those in need (assuming they exist) will find out and
> >complain and possibly we will move this code to a more appropriate
> >place. Where, i just have no idea.
> 
> Well, I guess you could say that I complained. I'll send a request to 
> the cvsmeisters for a repo copy to (yet) another location.

you are not in need -- you just asked who could be using it
and did not positively mention anyone.
Not that i am opposed to keeping it, just i do not see any
use...

> >In any case the dd hack is as much of a hack as the one in
> >write_mfs_in_kernel.c, and it is not bad at all:
> >
> >     set `strings -at d kernel | grep "MFS Filesystem goes here"`
> >     mfs_ofs=$(($1 + 8192))
> >     dd if=${c_fs} ibs=8192 iseek=1 of=kernel obs=${mfs_ofs} \
> >	    oseek=1 conv=notrunc
> 
> Well, write_mfs_in_kernel does a bit more error checking to ensure 
> the user isn't shooting themselves in the foot.

the only additional check is that the area where you would 'dd'
the data is all-zero. You still have plenty of ways to shoot
yourself in the foot by passing an invalid mfs image as argument
(and if the kernel area is non-zero, you _are_ passing an invalid
argument, the kernel in this case).

	cheers
	luigi

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020714095839.H74633>