Date: Thu, 26 Nov 2020 23:23:11 +0100 From: Stefan Esser <se@freebsd.org> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: "O. Hartmann" <ohartmann@walstatt.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r368072 - in head/contrib/bc: . gen include manuals manuals/bc manuals/dc src src/bc src/dc src/history src/rand tests Message-ID: <94afc036-0c96-589b-47a4-7d9972b642cc@freebsd.org> In-Reply-To: <aee14858-17ac-54c2-97e1-91938bee819a@freebsd.org> References: <202011261739.0AQHdpe5012982@repo.freebsd.org> <20201126191949.092c9eba@thor.intern.walstatt.dynvpn.de> <95c3e226-6050-2f91-debf-317d6d11494f@freebsd.org> <202011262003.0AQK3BTe076596@slippy.cwsent.com> <aee14858-17ac-54c2-97e1-91938bee819a@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--LNh7JZBKUks6iTmPthYYHSJRZLxtgUw39
Content-Type: multipart/mixed; boundary="UukPFASfKyppXv6KjFIjzyho2LVowmUF8";
protected-headers="v1"
From: Stefan Esser <se@freebsd.org>
To: Cy Schubert <Cy.Schubert@cschubert.com>
Cc: "O. Hartmann" <ohartmann@walstatt.org>, src-committers@freebsd.org,
svn-src-all@freebsd.org, svn-src-head@freebsd.org
Message-ID: <94afc036-0c96-589b-47a4-7d9972b642cc@freebsd.org>
Subject: Re: svn commit: r368072 - in head/contrib/bc: . gen include manuals
manuals/bc manuals/dc src src/bc src/dc src/history src/rand tests
References: <202011261739.0AQHdpe5012982@repo.freebsd.org>
<20201126191949.092c9eba@thor.intern.walstatt.dynvpn.de>
<95c3e226-6050-2f91-debf-317d6d11494f@freebsd.org>
<202011262003.0AQK3BTe076596@slippy.cwsent.com>
<aee14858-17ac-54c2-97e1-91938bee819a@freebsd.org>
In-Reply-To: <aee14858-17ac-54c2-97e1-91938bee819a@freebsd.org>
--UukPFASfKyppXv6KjFIjzyho2LVowmUF8
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
FYI: Another "make buildworld" has succeeded on my system.
I cannot reproduce the issue your report and need more
information from your system, e.g. a TAR file with the
contents of usr.bin/gh-bc, contrib/bc and your object
directory ${.OBJDIR}.
Regards, STefan
Am 26.11.20 um 22:23 schrieb Stefan Esser:
> Am 26.11.20 um 21:03 schrieb Cy Schubert:> But this is still a problem:=
>>
>> ld: error: undefined symbol: bc_lib_name
>>>>> referenced by vm.c:752 (/opt/src/svn-current/contrib/bc/src/vm.c:75=
2)
>>>>> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 lto.tmp:(bc_vm_boot)
>>
>> ld: error: undefined symbol: bc_lib
>>>>> referenced by lex.c:225=20
>>>>> (/opt/src/svn-current/contrib/bc/src/lex.c:225)
>>>>> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 lto.tmp:(bc_vm_boot)
>>>>> referenced by lex.c:227=20
>>>>> (/opt/src/svn-current/contrib/bc/src/lex.c:227)
>>>>> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 lto.tmp:(bc_vm_boot)
>> cc: error: linker command failed with exit code 1 (use -v to see=20
>> invocation)
>> *** [gh-bc.full] Error code 1
>=20
> I cannot reproduce this issue on my system.
>=20
> The symbols are defined in files generated by gen/strgen.sh and
> there was a change in the parameters passed to this script, but
> I had fixed usr.bin/gh-bc/Makefile accordingly (first in the port
> and then in base).
>=20
> The generated file lib.c should start like this:
> -----------------------------------------------------------------
> // Copyright (c) 2018-2020 Gavin D. Howard and contributors.
> // Licensed under the 2-clause BSD license.
> // *** AUTOMATICALLY GENERATED FROM gen/lib.bc. DO NOT MODIFY. ***
>=20
> #if 1
> extern const char *bc_lib_name;
>=20
> extern const char bc_lib[];
>=20
> const char *bc_lib_name =3D "gen/lib.bc";
>=20
> const char bc_lib[] =3D
> "scale=3D20\n"
> -----------------------------------------------------------------
>=20
> This file is generated by this rule in usr.bin/gh-bc/Makefile:
>=20
> lib.c:=A0=A0=A0=A0=A0=A0=A0=A0=A0 lib.bc
> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 cd ${BCDIR} && sh gen/st=
rgen.sh gen/lib.bc=20
> ${.OBJDIR}/lib.c bc_lib bc_lib_name 1 1
>=20
> By a script that assigns parameters to variables:
>=20
> input=3D"$1"
> output=3D"$2"
> name=3D"$3"
> label=3D"$4"
> define=3D"$5"
> remove_tabs=3D"$6"
>=20
> And label=3D"bc_lib_name" is used to generate lib.c as included
> above (passed as 4th parameter).
>=20
> I'm rebuilding a clean world, now, but I'd be surprised if it failed
> after succeeding before readying the commit ...
>=20
> Regards, STefan
>=20
--UukPFASfKyppXv6KjFIjzyho2LVowmUF8--
--LNh7JZBKUks6iTmPthYYHSJRZLxtgUw39
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"
-----BEGIN PGP SIGNATURE-----
wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAl/AKs8FAwAAAAAACgkQR+u171r99UTb
PQgAyB516biVoiagMuoLx2hEWmFtSVi81YJp89y0LMutWOiQNEqo7vSjDSp8lQFIxzLvuJs3ycyb
tv3LdoHVZHAJHUc/Tyxzs2DAbiUnyF5p6zhYRkUIZjnW7NVF0PF5MiWZzhMjnNOczsFPdrBvY6Ey
q1UoxrPLBFXavi53Q36q9ZuJFI7cv1l5Vsll+G0tAZzu4PXJQ6EDRhkQGpGWbvDb3gqIjnc2peEE
tT0JfT6jo6/hNPTTvFo8McYeiwYqAXooa+mH/xjbq3WjGZ9s+vknr+pleH5YGYEP8NaNc+bzxZLk
pehxZTxhS71hnvwtgf6ZWiH1QNzRNuWacHkPJy9gQg==
=Vfzz
-----END PGP SIGNATURE-----
--LNh7JZBKUks6iTmPthYYHSJRZLxtgUw39--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?94afc036-0c96-589b-47a4-7d9972b642cc>