Date: Sat, 10 Jan 2026 09:11:25 +0100 From: Michal Meloun <mmel@FreeBSD.org> To: Emmanuel Vadot <manu@bidouilliste.com>, Warner Losh <imp@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org, Martin Filla <freebsd@sysctl.cz> Subject: Re: git: b55d106df978 - main - ophgo: import new .dts Message-ID: <f5394d7a-b9dd-4403-ae3b-dfe322788fdf@FreeBSD.org> In-Reply-To: <20260110083217.756db8eed35624274459e1fb@bidouilliste.com> References: <6961de2f.34d1b.37ee2089@gitrepo.freebsd.org> <20260110083217.756db8eed35624274459e1fb@bidouilliste.com>
index | next in thread | previous in thread | raw e-mail
On 10.01.2026 8:32, Emmanuel Vadot wrote: > > Hello, > > On Sat, 10 Jan 2026 05:05:51 +0000 > Warner Losh <imp@FreeBSD.org> wrote: > >> The branch main has been updated by imp: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=b55d106df9785d141f9e3e1c916e921df9d877ac >> >> commit b55d106df9785d141f9e3e1c916e921df9d877ac >> Author: Martin Filla <freebsd@sysctl.cz> >> AuthorDate: 2025-09-09 14:34:38 +0000 >> Commit: Warner Losh <imp@FreeBSD.org> >> CommitDate: 2026-01-10 05:05:38 +0000 >> >> ophgo: import new .dts >> >> Signed-off-by: Martin Filla <freebsd@sysctl.cz> >> Reviewed by: imp >> Pull Request: https://github.com/freebsd/freebsd-src/pull/1844 >> --- >> .../include/dt-bindings/clock/cv181x-clock.h | 175 ++++ >> .../include/dt-bindings/dma/cv181x-dmamap.h | 48 ++ >> .../include/dt-bindings/reset/cv181x-resets.h | 172 ++++ >> .../src/riscv/sophgo/cv181x_asic_bga.dtsi | 56 ++ >> .../src/riscv/sophgo/cv181x_asic_emmc.dtsi | 4 + >> .../src/riscv/sophgo/cv181x_asic_qfn.dtsi | 120 +++ >> .../src/riscv/sophgo/cv181x_asic_sd.dtsi | 4 + >> .../src/riscv/sophgo/cv181x_asic_spinand.dtsi | 5 + >> .../src/riscv/sophgo/cv181x_asic_spinor.dtsi | 5 + >> .../device-tree/src/riscv/sophgo/cv181x_base.dtsi | 932 +++++++++++++++++++++ >> .../src/riscv/sophgo/cv181x_base_arm.dtsi | 320 +++++++ >> .../src/riscv/sophgo/cv181x_base_riscv.dtsi | 378 +++++++++ >> .../src/riscv/sophgo/cv181x_default_memmap.dtsi | 25 + >> .../sophgo/sg2000_milkv_duos_glibc_arm64_emmc.dts | 108 +++ >> .../sophgo/sg2000_milkv_duos_glibc_arm64_sd.dts | 112 +++ >> .../sophgo/sg2000_milkv_duos_musl_riscv64_emmc.dts | 108 +++ >> .../sophgo/sg2000_milkv_duos_musl_riscv64_sd.dts | 108 +++ >> .../src/riscv/sophgo/sg2000_wevb_arm64_sd.dts | 13 + >> .../src/riscv/sophgo/sg2000_wevb_riscv64_sd.dts | 10 + >> sys/modules/dtb/sophgo/Makefile | 15 + >> sys/riscv/conf/GENERIC | 1 + >> sys/riscv/conf/std.sophgo | 8 + >> sys/riscv/sophgo/files.sophgo | 2 + >> 23 files changed, 2729 insertions(+) >> > > This adds a lots of files to sys/contrib/device-tree, I though we said > that this directory should be mostly pristine compared to upstream and > only contain small modifications. > I do not see those files in latest upstream too, but there is some > sophgo related stuff in there, where do those files comes from ? > +1 Vendor DTs are very rarely accepted by mainstream in compatible manner. Importing them therefore spells nightmare for future updates. Also, adding "sys/riscv/conf/std.sophgo" and "sys/riscv/sophgo/files.sophgo" without any basic SoC driver (clock, reset, pinctrl) does not sounds right. Michalhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f5394d7a-b9dd-4403-ae3b-dfe322788fdf>