Date: Tue, 28 Nov 2023 13:38:40 GMT From: Roger Pau =?utf-8?Q?Monn=C3=A9?= <royger@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: d48760ffe9ea - main - xen/dev: remove __unused from driver argument of identify functions Message-ID: <202311281338.3ASDcemX025589@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by royger: URL: https://cgit.FreeBSD.org/src/commit/?id=d48760ffe9eaac809f8d31fb1b4e6b13ae52d59a commit d48760ffe9eaac809f8d31fb1b4e6b13ae52d59a Author: Elliott Mitchell <ehem+freebsd@m5p.com> AuthorDate: 2023-09-27 05:39:22 +0000 Commit: Roger Pau Monné <royger@FreeBSD.org> CommitDate: 2023-11-28 12:32:57 +0000 xen/dev: remove __unused from driver argument of identify functions The driver argument is most certainly now used by these functions. When originally implemented it might have been unused, but not now. Reviewed by: royger --- sys/dev/xen/balloon/balloon.c | 2 +- sys/dev/xen/control/control.c | 2 +- sys/dev/xen/grant_table/grant_table.c | 2 +- sys/dev/xen/xenstore/xenstore_dev.c | 2 +- sys/dev/xen/xenstore/xenstored_dev.c | 2 +- sys/xen/xenbus/xenbusb.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/sys/dev/xen/balloon/balloon.c b/sys/dev/xen/balloon/balloon.c index 6db910e60dd3..c6ff8fc782c6 100644 --- a/sys/dev/xen/balloon/balloon.c +++ b/sys/dev/xen/balloon/balloon.c @@ -334,7 +334,7 @@ watch_target(struct xs_watch *watch, * \param parent The NewBus parent device for any devices this method adds. */ static void -xenballoon_identify(driver_t *driver __unused, device_t parent) +xenballoon_identify(driver_t *driver, device_t parent) { /* * A single device instance for our driver is always present diff --git a/sys/dev/xen/control/control.c b/sys/dev/xen/control/control.c index 37b4bff709c7..1dc1df935b84 100644 --- a/sys/dev/xen/control/control.c +++ b/sys/dev/xen/control/control.c @@ -401,7 +401,7 @@ xctrl_on_watch_event(struct xs_watch *watch, const char **vec, unsigned int len) * \param parent The NewBus parent device for any devices this method adds. */ static void -xctrl_identify(driver_t *driver __unused, device_t parent) +xctrl_identify(driver_t *driver, device_t parent) { /* * A single device instance for our driver is always present diff --git a/sys/dev/xen/grant_table/grant_table.c b/sys/dev/xen/grant_table/grant_table.c index c9d7d1e66af0..394d40c5d49c 100644 --- a/sys/dev/xen/grant_table/grant_table.c +++ b/sys/dev/xen/grant_table/grant_table.c @@ -569,7 +569,7 @@ MTX_SYSINIT(gnttab, &gnttab_list_lock, "GNTTAB LOCK", MTX_DEF | MTX_RECURSE); * \param parent The NewBus parent device for any devices this method adds. */ static void -granttable_identify(driver_t *driver __unused, device_t parent) +granttable_identify(driver_t *driver, device_t parent) { KASSERT(xen_domain(), diff --git a/sys/dev/xen/xenstore/xenstore_dev.c b/sys/dev/xen/xenstore/xenstore_dev.c index 65ca9d67ce4f..0dcf6938d5fb 100644 --- a/sys/dev/xen/xenstore/xenstore_dev.c +++ b/sys/dev/xen/xenstore/xenstore_dev.c @@ -474,7 +474,7 @@ static struct cdevsw xs_dev_cdevsw = { * \param parent The NewBus parent device for any devices this method adds. */ static void -xs_dev_identify(driver_t *driver __unused, device_t parent) +xs_dev_identify(driver_t *driver, device_t parent) { /* * A single device instance for our driver is always present diff --git a/sys/dev/xen/xenstore/xenstored_dev.c b/sys/dev/xen/xenstore/xenstored_dev.c index 13cc7c3b36d8..26ff3083e68c 100644 --- a/sys/dev/xen/xenstore/xenstored_dev.c +++ b/sys/dev/xen/xenstore/xenstored_dev.c @@ -95,7 +95,7 @@ xsd_dev_mmap(struct cdev *dev, vm_ooffset_t offset, vm_paddr_t *paddr, * \param parent The NewBus parent device for any devices this method adds. */ static void -xsd_dev_identify(driver_t *driver __unused, device_t parent) +xsd_dev_identify(driver_t *driver, device_t parent) { if (!xen_domain() || xs_initialized()) diff --git a/sys/xen/xenbus/xenbusb.c b/sys/xen/xenbus/xenbusb.c index 0e303fc83f15..12a921eab8b1 100644 --- a/sys/xen/xenbus/xenbusb.c +++ b/sys/xen/xenbus/xenbusb.c @@ -622,7 +622,7 @@ xenbusb_nop_confighook_cb(void *arg __unused) /*--------------------------- Public Functions -------------------------------*/ /*--------- API comments for these methods can be found in xenbusb.h ---------*/ void -xenbusb_identify(driver_t *driver __unused, device_t parent) +xenbusb_identify(driver_t *driver, device_t parent) { /* * A single instance of each bus type for which we have a driver
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202311281338.3ASDcemX025589>