Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 18 Jul 2001 15:44:25 +0300
From:      Alexey Zelkin <phantom@FreeBSD.org.ua>
To:        Mike Barcroft <mike@FreeBSD.org>
Cc:        audit@FreeBSD.org, Dag-Erling Smorgrav <des@ofug.org>
Subject:   Re: whois(1) changes
Message-ID:  <20010718154425.A65945@phantom.cris.net>
In-Reply-To: <20010717214524.A51455@coffee.q9media.com>; from mike@FreeBSD.org on Tue, Jul 17, 2001 at 09:45:24PM -0400
References:  <20010717214524.A51455@coffee.q9media.com>

next in thread | previous in thread | raw e-mail | index | archive | help
hi,

On Tue, Jul 17, 2001 at 09:45:24PM -0400, Mike Barcroft wrote:
> 
> I would appreciate comments on the patch to whois(1) located at the
> end of this e-mail and also available at:
> http://people.FreeBSD.org/~mike/patches/whois.20010718.patch
> 
> If there are no objections, I plan on committing it in a two days.
>
> ---------------------------------------------------------------------
> 
> whois.20010717.patch
> 
> o Reintegrate part of phantom's patch which adds gethostinfo().
> o Create a wrapper for asprintf(3) which checks for failure.
> o Tested on i386, alpha.

[patch skiped]

1. isdigit()'s argument should be explicitly casted to 'unsigned char' per
ache's guidelines.

2. I think it's time to go thru include files and cleanup it.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010718154425.A65945>