Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 28 Feb 2020 21:31:41 +0000 (UTC)
From:      Emmanuel Vadot <manu@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r358450 - head/sys/dev/mmc/host
Message-ID:  <202002282131.01SLVfG4082666@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: manu
Date: Fri Feb 28 21:31:40 2020
New Revision: 358450
URL: https://svnweb.freebsd.org/changeset/base/358450

Log:
  mmc: dwmmc: Fix off by one error
  
  The IVAR_MAX_DATA is supposed to have the number of descriptor X the mmc
  block size and desc_count contain all this information + 1.
  
  Reported by:	phk
  MFC after:	1 week

Modified:
  head/sys/dev/mmc/host/dwmmc.c

Modified: head/sys/dev/mmc/host/dwmmc.c
==============================================================================
--- head/sys/dev/mmc/host/dwmmc.c	Fri Feb 28 21:13:15 2020	(r358449)
+++ head/sys/dev/mmc/host/dwmmc.c	Fri Feb 28 21:31:40 2020	(r358450)
@@ -1278,7 +1278,7 @@ dwmmc_read_ivar(device_t bus, device_t child, int whic
 		*(int *)result = sc->host.caps;
 		break;
 	case MMCBR_IVAR_MAX_DATA:
-		*(int *)result = sc->desc_count;
+		*(int *)result = sc->desc_count - 1;
 		break;
 	case MMCBR_IVAR_TIMING:
 		*(int *)result = sc->host.ios.timing;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202002282131.01SLVfG4082666>