Date: Tue, 21 Jul 2015 14:59:07 -0700 From: David Wolfskill <david@catwhisker.org> To: Eric van Gyzen <eric@vangyzen.net> Cc: Konstantin Belousov <kostikbel@gmail.com>, current@freebsd.org, net@freebsd.org, Randall Stewart <rrs@freebsd.org> Subject: Re: panic: witness_warn head/amd64 @r285741 on 1 of 2 machines Message-ID: <20150721215907.GM27865@albert.catwhisker.org> In-Reply-To: <55AEA9BC.5070806@vangyzen.net> References: <20150721125734.GF1217@albert.catwhisker.org> <20150721133907.GR2404@kib.kiev.ua> <20150721161927.GN1217@albert.catwhisker.org> <20150721191743.GA39506@muskytusk> <20150721192832.GB2404@kib.kiev.ua> <20150721200515.GD27865@albert.catwhisker.org> <55AEA9BC.5070806@vangyzen.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Tue, Jul 21, 2015 at 03:21:16PM -0500, Eric van Gyzen wrote:
> ...
> >> So it looks like net swi, leaking some udp6 lock.
> > Curiouser and curiouser... While I'm not taking any special pains to
> > avoid building IPv6, I'm not actively actually doing anything with it
> > (IPv6), either (for both the failing machine and my laptop).
> >
> > Once I'm back home, I should be able to poke around in ddb after
> > re-creating the panic, if that would be a useful thing for me to do (and
> > given some hints as to what to poke).
> >
> > Naturally, I'm also happy to change bits of sources, rebuild, and
> > smoke-test.
> >
> > A quick check from the SVN update output only shows r285710, r285711, and
> > r285740 in the range from (r285685,r285741] -- as the kernel running
> > r285685 had no known issues -- that touched sys/netinet6/*.
>
> It's a multicast destination. Maybe something is using mDNS?
>
> Randall, does the test on line 406 of udp6_usrreq.c need to be inverted?
>
> Eric
>
<DING!> We have a winner!
FreeBSD freebeast.catwhisker.org 11.0-CURRENT FreeBSD 11.0-CURRENT #1789 r285741M/285741:1100077: Tue Jul 21 14:50:59 PDT 2015 root@freebeast.catwhisker.org:/common/S3/obj/usr/src/sys/GENERIC amd64
freebeast(11.0-C)[3] cd /usr/src
freebeast(11.0-C)[4] svn diff sys/netinet
netinet/ netinet6/
freebeast(11.0-C)[4] svn diff sys/netinet*
Index: sys/netinet6/udp6_usrreq.c
===================================================================
--- sys/netinet6/udp6_usrreq.c (revision 285741)
+++ sys/netinet6/udp6_usrreq.c (working copy)
@@ -403,7 +403,7 @@
INP_RLOCK(last);
INP_INFO_RUNLOCK(pcbinfo);
UDP_PROBE(receive, NULL, last, ip6, last, uh);
- if (udp6_append(last, m, off, &fromsa))
+ if (! udp6_append(last, m, off, &fromsa))
INP_RUNLOCK(last);
inp_lost:
return (IPPROTO_DONE);
freebeast(11.0-C)[5]
Thanks! :-)
Peace,
david
--
David H. Wolfskill david@catwhisker.org
Those who murder in the name of God or prophet are blasphemous cowards.
See http://www.catwhisker.org/~david/publickey.gpg for my public key.
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQJ8BAEBCgBmBQJVrsCrXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ4RThEMDY4QTIxMjc1MDZFRDIzODYzRTc4
QTY3RjlDOERFRjQxOTNCAAoJEIpn+cje9Bk7cNwP+wTdwhcPKxKf7R93PSf7cYx9
WMB5SRTs4MM5ddz0w9mEajNSILxVqtHOcaJqDgzZiksvQAJkiX7Q1x2ruq0Qua+Z
YgI2s8Y3Z+xcNucaKrMOQdClyNnqNVFlAilNgTqmp3fVNi6ANYOpQOt3JDaQojVx
NrlgU/JuwXMrGic1EIXM7Q1XhHTCm56I4AnCSXezoU511TGTlR3cqKSEyyyHVsRk
3amxUiCPQzqKj1+8SNQuZeZgnXMAyiyoyStFQS5dWlS7UIVvRbZYvu0kQlBleFD9
QAgNURS56hwBnpufq8UpE9QmOj7umv8uqtDRRp8LqdmcsMUikqmGBhQr2uWwI6gy
DTSq9Fy1BR+brmkklMbG5lP5rrYnOGVokif4SvZfM5HSSMiQJ1xRHzmpFYYlwHnf
W89m2ZarLDoWzEWJZFUioCiMNRqs9yea8frQefNyq0Shv2iUesZYGpvjg6jiyyBr
V7nYag5f7p22h0glcBSa2CML/6VYAc8DflPAT8qCXzITTZ7R144gw/pMJK0Bil7Q
PJ6SixCpJS+wQjVs6/9MDzbp7u1gh3C98ZXnZDeeS1Iz8ioMnNLkfRvMHDRzLBeh
+PVoS8uNWEw7LEAOSdy/v2218u0hprFj/14nV1OCSEYmf/vG8LTIfqsGgLfE9TK4
1QHMarwpud2GyApE+NH0
=iwnN
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150721215907.GM27865>