Date: Tue, 18 Aug 2020 05:58:25 -0700 From: David Wolfskill <david@catwhisker.org> To: Mateusz Guzik <mjguzik@gmail.com> Cc: current@freebsd.org Subject: Re: "panic: malloc(M_WAITOK) in non-sleepable context" after r364296 -> r364341 Message-ID: <20200818125825.GP1394@albert.catwhisker.org> In-Reply-To: <CAGudoHEEnZVaBwY1L-wjmDcrsHyP4pE3-0qyurh-kWsCO9Edhg@mail.gmail.com> References: <20200818124419.GO1394@albert.catwhisker.org> <CAGudoHEEnZVaBwY1L-wjmDcrsHyP4pE3-0qyurh-kWsCO9Edhg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--xP4xvRzdEG0QZ+Pj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 18, 2020 at 02:48:47PM +0200, Mateusz Guzik wrote: > see https://reviews.freebsd.org/D26027 > .... Right; I was just reviewing the list of updated files and noted src/sys/kern/kern_malloc.c, and its svn log showed: ------------------------------------------------------------------------ r364310 | glebius | 2020-08-17 08:37:08 -0700 (Mon, 17 Aug 2020) | 8 lines With INVARIANTS panic immediately if M_WAITOK is requested in a non-sleepable context. Previously only _sleep() would panic. This will catch misuse of M_WAITOK at development stage rather than at stress load stage. Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D26027 ------------------------------------------------------------------------ And if we were still going in to the office, I'd discuss it with Gleb. :-) But in the mean time: I'm not a committer; I didn't cause the error. Seems I can't try running head now with a GENERIC kernel. Peace, david --=20 David H. Wolfskill david@catwhisker.org Donald Trump is either ignorant of how to govern or is refusing to do so. See http://www.catwhisker.org/~david/publickey.gpg for my public key. --xP4xvRzdEG0QZ+Pj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEE4owz2QxMJyaxAefyQLJg+bY2PckFAl870HFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEUy OEMzM0Q5MEM0QzI3MjZCMTAxRTdGMjQwQjI2MEY5QjYzNjNEQzkACgkQQLJg+bY2 PcnT8QgAkVRRNjyVakVRitID8d9WSEvKJcRZx9ICemFxZFuvHthIJzrwvRSZ7aq/ dh2/JnYXOFcxV5WMexASAtdcHgkziUddxJe5vhPoaV6jXiocYQTdGyOZEeLphKhU k6rW+5SlqLdP2kqFIR2tFF3pkkNuNfhjdAWKY/RwRpFcOEG4bQ6U+9tV9T7Ktj/3 Nlef9tpYhLaDraYjRgiEQL1q8AE6jQ5hrSG3NOO8PnfdUlzqkYB9o/cbJn0s/fyX B46OwFbIsKQR5eKrF+NLwNpI+1HDrP6rYHAox7zb/lHTvk5fnnZh0bevwZ07080v kPp0kdhZqw623gX9prBxbd9ni/NRgg== =OxMD -----END PGP SIGNATURE----- --xP4xvRzdEG0QZ+Pj--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200818125825.GP1394>