Date: Thu, 24 Jul 2025 14:56:09 -0500 From: Kyle Evans <kevans@FreeBSD.org> To: Cy Schubert <Cy.Schubert@cschubert.com>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 962876cc24ee - main - UPDATING: Note the Kerberos package rename (c7da9fb90b0b) Message-ID: <8200b60d-fcf9-431f-a417-7c0865feefd3@FreeBSD.org> In-Reply-To: <20250724193611.5FEAB54F@slippy.cwsent.com> References: <202507241824.56OIO88s005888@gitrepo.freebsd.org> <20250724190526.2F85A642@slippy.cwsent.com> <aIKImiqbMx_oAoZJ@freefall.freebsd.org> <20250724193611.5FEAB54F@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7/24/25 14:36, Cy Schubert wrote: > In message <aIKImiqbMx_oAoZJ@freefall.freebsd.org>, Lexi Winter writes: >> >> >> --/cJljwJYtPl3uHOB >> Content-Type: text/plain; charset=us-ascii >> Content-Disposition: inline >> Content-Transfer-Encoding: quoted-printable >> >> hi Cy, >> >> Cy Schubert: >>> In message <202507241824.56OIO88s005888@gitrepo.freebsd.org>, Lexi Winter= >> =20 >>> writes: >>>> UPDATING: Note the Kerberos package rename (c7da9fb90b0b) >> =20 >>> Shouldn't this be the other way around? Heimdal is FreeBSD-kerberos while= >> =20 >>> MIT is FreeBSD-krb5. I objected to the name change because it could cause= >> =20 >>> people to assume they were one in the same. >> >> although i understand you objected to D51420, i landed it anyway[0] >> which means the packages are back to their old names and there are >> no more FreeBSD-krb5* packages. >> >> let me explain why i did this: >> >> - the change to the package names caused friction both inside the >> project (e.g., it broke the OCI build scripts) and outside the >> project (according to reports i received from downstream users). >> >> - it was not clear there is any advantage to renaming the packages. >> >> - due to above i was specifically asked to land this commit by several >> people, including a pkgbase maintainer, and one of my mentors at the >> time. >> >> - i considered this a reasonable course of action because this restored >> the previous status quo and undid a change that (as far as i'm aware) >> hadn't been reviewed by #pkgbase, so in case of doubt, i erred on the >> side of restoring the previous behaviour. >> >> i apologise for reverting your code over your stated objections but now >> that we are back to the previous behaviour, we can discuss whether to >> rename these packages, which i suggest doing via a Phabricator review >> that includes #pkgbase. > > No offense taken. I'm ok if those using the packages understand fully. > > Do people want /usr/src/krb5 renamed to /usr/src/kerberos5 when Heimdal is > removed? I'm open to this. > IMO it's fine to stay where it is; krb5 is a designation given to it elsewhere (upstream?), not just a FreeBSD-ism. If it were hard to recognize what that may be for someone familiar with Kerberos implementations it'd be more tempting to move it. I do think we should add a note to ^/README.md with a short description of the krb5/ directory, though. Thanks, Kyle Evans
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8200b60d-fcf9-431f-a417-7c0865feefd3>