Date: Wed, 25 Aug 2010 17:43:31 +0300 From: Andriy Gapon <avg@icyb.net.ua> To: Ollivier Robert <roberto@keltia.freenix.fr> Cc: freebsd-fs@freebsd.org Subject: Re: zfs arc - just take it all and be good to me Message-ID: <4C752C13.3080508@icyb.net.ua> In-Reply-To: <20100825132131.GA56434@roberto-al.eurocontrol.fr> References: <20100811014919.GA52992@icarus.home.lan> <20100811192537.GA44635@tolstoy.tols.org> <AANLkTin-YvEzoN-ThwwDAqn2mWFMD4-7BnP8N95EqTk0@mail.gmail.com> <20100811214302.GB44635@tolstoy.tols.org> <20100812205625.GA79515@server.vk2pj.dyndns.org> <20100824150035.GB99477@roberto-al.eurocontrol.fr> <20100824200527.GC11990@server.vk2pj.dyndns.org> <4C742C8F.2030401@icyb.net.ua> <20100824215508.GA15597@lonrach.keltia.net> <4C744417.8080106@icyb.net.ua> <20100825132131.GA56434@roberto-al.eurocontrol.fr>
next in thread | previous in thread | raw e-mail | index | archive | help
on 25/08/2010 16:21 Ollivier Robert said the following: > According to Andriy Gapon: >> Could you please double-check? Is the check for vm_paging_needed() indeed? >> That could have been a slightly different patch. > > 695 [15:19] root@centre:src/sys# svn diff cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c > Index: cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c > =================================================================== > --- cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c (revision 210515) > +++ cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c (working copy) > @@ -2123,8 +2123,9 @@ > /* > * If pages are needed or we're within 2048 pages > * of needing to page need to reclaim > + * XXX Try to workaround zfs overzealousness from gav/avg > */ > - if (vm_pages_needed || (vm_paging_target() > -2048)) > + if (vm_pages_needed) > return (1); Note that vm_pages_needed != vm_paging_needed(). Talk about confusing :) -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C752C13.3080508>