Date: Tue, 30 Sep 2025 19:51:05 +0200 From: Kristof Provost <kp@FreeBSD.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: ItzBlinkzy <kitey13579@gmail.com>, Kevin Irabor <kevin.irabor04@gmail.com>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4e7a375804e5 - main - IfAPI: Added missing accessor for if_home_vnet Message-ID: <9E63C594-08DD-43CD-BD76-3E9B9E80AA60@FreeBSD.org> In-Reply-To: <aNwVz6wL5cLbmYqR@cell.glebi.us> References: <202509292116.58TLGxWx078766@gitrepo.freebsd.org> <aNwVz6wL5cLbmYqR@cell.glebi.us>
next in thread | previous in thread | raw e-mail | index | archive | help
On 30 Sep 2025, at 19:39, Gleb Smirnoff wrote: > On Mon, Sep 29, 2025 at 09:16:59PM +0000, Kristof Provost wrote: > K> URL: https://cgit.FreeBSD.org/src/commit/?id=3D4e7a375804e5ad4b244ce= 9a035fa971cbf2f0944 > K> > K> commit 4e7a375804e5ad4b244ce9a035fa971cbf2f0944 > K> Author: ItzBlinkzy <kitey13579@gmail.com> > K> AuthorDate: 2025-09-28 17:21:41 +0000 > K> Commit: Kristof Provost <kp@FreeBSD.org> > K> CommitDate: 2025-09-29 21:15:55 +0000 > K> > K> IfAPI: Added missing accessor for if_home_vnet > K> > K> Reviewed by: kp > K> Signed-off-by: Kevin Irabor <kevin.irabor04@gmail.com> > > So, who is the actual author of the patch kitey13579@gmail.com or > <kevin.irabor04@gmail.com>? > I=E2=80=99d assume they=E2=80=99re the same person, but yeah, it=E2=80=99= s not ideal. I pulled this from GitHub and missed the discrepancy. > The actual question is whether there is a driver that really needs to a= ccess > this field or was this added by the logic that if a field exists in str= uct > ifnet, a function to access it shall exist? > It=E2=80=99s hard to predict what fields will be relevant for out-of-tree= consumers, but it seems reasonable to allow access to this one given we = already allow the current vnet to be accessed too. Best regards, Kristof
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9E63C594-08DD-43CD-BD76-3E9B9E80AA60>