Date: Tue, 2 Jul 2013 16:20:59 -0700 From: Steve Kargl <sgk@troutmask.apl.washington.edu> To: Dimitry Andric <dim@FreeBSD.org> Cc: Ed Schouten <ed@80386.nl>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: [PATCH] nvmecontrol breaks world Message-ID: <20130702232059.GA69299@troutmask.apl.washington.edu> In-Reply-To: <7513EF4A-7808-4DC5-B60E-3AE93ECF85D1@FreeBSD.org> References: <20130702201728.GA68544@troutmask.apl.washington.edu> <CAJOYFBCWzzT7kSABROsyJsbt%2BN=KhQ3vmW4TJjw3Toxsxu836A@mail.gmail.com> <7513EF4A-7808-4DC5-B60E-3AE93ECF85D1@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 02, 2013 at 10:37:35PM +0200, Dimitry Andric wrote: > On Jul 2, 2013, at 22:30, Ed Schouten <ed@80386.nl> wrote: > > 2013/7/2 Steve Kargl <sgk@troutmask.apl.washington.edu>: > >> Could someone (this could even be me, but need approval) please > >> fix nvmecontrol? > > > > off_t doesn't need to be intmax_t, right? Maybe add an explicit cast? > > Yes, that is what Bruce has suggested for off_t many times in the past. :-) > > > > Also, the call of malloc(sb.st_size) is not really safe... > > Sure, but that does not break buildworld (for gcc users, I assume? the tinderboxes are all green). > A gcc-only buildworld is broken on i386 without my patch. See http://lists.freebsd.org/pipermail/svn-src-all/2013-July/070954.html -- Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130702232059.GA69299>