Date: Wed, 5 Jan 2022 14:22:54 -0700 From: Warner Losh <imp@bsdimp.com> To: Ed Maste <emaste@freebsd.org> Cc: Mateusz Guzik <mjguzik@gmail.com>, Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 5a73a6c178f6 - main - Add lio back to NOTES Message-ID: <CANCZdfr42dYG6FVGVQbu=ar6B5_Tb0N4dus-xWjwYZToMdFZAg@mail.gmail.com> In-Reply-To: <CANCZdfp65xQjioaAVuYTzRU%2B1B0-xrWJFXHJ_xAyVbGhz=7VCQ@mail.gmail.com> References: <202112312157.1BVLvLhd040939@gitrepo.freebsd.org> <CAGudoHF_g6f2FDx_DnGCpkNRF6mK1FCPf9vet46RPUKQ618Pcg@mail.gmail.com> <CANCZdfpYRxdgaxVbc1xEozy7w8tbSMNYmXJTGE3veuO2VAOasQ@mail.gmail.com> <CAPyFy2AaECceQFpJrF90sxWQ-NHfg31Qw210AcUGE3H3QGXL1g@mail.gmail.com> <CANCZdfp65xQjioaAVuYTzRU%2B1B0-xrWJFXHJ_xAyVbGhz=7VCQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000ff040105d4dc5b59 Content-Type: text/plain; charset="UTF-8" On Wed, Jan 5, 2022 at 2:09 PM Warner Losh <imp@bsdimp.com> wrote: > > > On Wed, Jan 5, 2022 at 2:06 PM Ed Maste <emaste@freebsd.org> wrote: > >> On Wed, 5 Jan 2022 at 15:47, Warner Losh <imp@bsdimp.com> wrote: >> > >> > NOIP kernels were already broken when I made this commit. I'll take a >> look now that emaste committed fixes for those... >> >> I think w/o INET should have built as of my a6668e31aa3c commit. >> >> I also tried building without both INET and INET6. A number of drivers >> have checksum offload support that calls in_pseudo() (or similar) >> without #ifdef guards, and in_pseduo isn't available in that case. >> After hacking those cases I was able to build without INET and INET6. >> >> Affected drivers: age alc ale bxe fxp jme msk sge sk >> > > Yea, a6668e31aa3c was after my adding lio back. But I'll take a look. > lio just needs to be added to the NOIP exclusion list. Committed a change for that. Sorry for the breakage. Warner --000000000000ff040105d4dc5b59 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">= <div dir=3D"ltr" class=3D"gmail_attr">On Wed, Jan 5, 2022 at 2:09 PM Warner= Losh <<a href=3D"mailto:imp@bsdimp.com">imp@bsdimp.com</a>> wrote:<b= r></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex= ;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">= <div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" = class=3D"gmail_attr">On Wed, Jan 5, 2022 at 2:06 PM Ed Maste <<a href=3D= "mailto:emaste@freebsd.org" target=3D"_blank">emaste@freebsd.org</a>> wr= ote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px= 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, 5 J= an 2022 at 15:47, Warner Losh <<a href=3D"mailto:imp@bsdimp.com" target= =3D"_blank">imp@bsdimp.com</a>> wrote:<br> ><br> > NOIP kernels were already broken when I made this commit. I'll tak= e a look now that emaste committed fixes for those...<br> <br> I think w/o INET should have built as of my a6668e31aa3c commit.<br> <br> I also tried building without both INET and INET6. A number of drivers<br> have checksum offload support that calls in_pseudo() (or similar)<br> without #ifdef guards, and in_pseduo isn't available in that case.<br> After hacking those cases I was able to build without INET and INET6.<br> <br> Affected drivers: age alc ale bxe fxp jme msk sge sk<br></blockquote><div><= br></div><div>Yea,=C2=A0a6668e31aa3c was after my adding lio back. But I= 9;ll take a look.</div></div></div></blockquote><div><br></div><div>lio jus= t needs to be added to the NOIP exclusion list. Committed a change for that= . Sorry for the breakage.</div><div><br></div><div>Warner=C2=A0</div></div>= </div> --000000000000ff040105d4dc5b59--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfr42dYG6FVGVQbu=ar6B5_Tb0N4dus-xWjwYZToMdFZAg>