Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 8 Mar 2016 08:10:10 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        wenheping <wenheping2000@hotmail.com>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r410453 - in head/math/fityk: . files
Message-ID:  <20160308081010.GA21062@FreeBSD.org>
In-Reply-To: <BLU168-W38C545AE14EE4DC0FF7394ACB20@phx.gbl>
References:  <201603061053.u26Arwc9042914@repo.freebsd.org> <20160307103754.GA45158@FreeBSD.org> <BLU168-W38C545AE14EE4DC0FF7394ACB20@phx.gbl>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 08, 2016 at 09:22:54AM +0800, wenheping wrote:
> In the whole portstree, there are many mute installations such as "@cd
> ${WRKSRC} && ${COPYTREE_SHARE}",

These are wrong.  Unfortunately, there're lots of bugs in the Makefiles
throughout the Ports Tree.

> and there are many 'not mute' installations such as "cd ${WRKSRC} &&
> ${COPYTREE_SHARE}" too.

These are correct.

> I did not find 'not mute installation" is wrong in Porter's Handbook.

It might not be articulated loud enough, but it's pretty obvious once you
think about it: muted commands won't appear in the build log, which makes
it harder to debug and fix any issues.

mkdir's are often muted because they do not have the same "debug value" as
installation commands, but all cp/COPYTREE_SHARE/ln/etc. commands should
not be muted.  This is pretty common knowledge in our community, I find it
strange that you've never heard of it.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160308081010.GA21062>