Date: Mon, 14 Nov 2005 17:57:42 +0300 (MSK) From: Maxim Konovalov <maxim@macomnet.ru> To: Craig Rodrigues <rodrigc@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/mount_msdosfs mount_msdosfs.c Message-ID: <20051114175556.L71805@mp2.macomnet.net> In-Reply-To: <20051114172424.R71372@mp2.macomnet.net> References: <200511130324.jAD3OihQ075601@repoman.freebsd.org> <20051114165703.X63316@mp2.macomnet.net> <20051114172424.R71372@mp2.macomnet.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 14 Nov 2005, 17:24+0300, Maxim Konovalov wrote:
> On Mon, 14 Nov 2005, 16:59+0300, Maxim Konovalov wrote:
>
> > On Sun, 13 Nov 2005, 03:24-0000, Craig Rodrigues wrote:
> >
> > > rodrigc 2005-11-13 03:24:44 UTC
> > >
> > > FreeBSD src repository
> > >
> > > Modified files:
> > > sbin/mount_msdosfs mount_msdosfs.c
> > > Log:
> > > Convert mount_msdosfs to use nmount().
> >
> > There is a regression now:
> >
> > $ grep /cf /etc/fstab
> > /dev/da0s1 /cf msdos moauto,ro,-m644,-M755,-umaxim,-gmaxim
> it's "noauto" of course^^^^^^
>
> > $ mount /cf
> > mount_msdosfs: /dev/da0s1: Invalid argument
> > $ dmesg | tail -1
> > mount option <auto> is unknown
> >
> > It works OK with rev. 1.36.
Moreover:
$ mount /cdrom
zsh: segmentation fault (core dumped) mount /cdrom
$ grep /cdrom /etc/fstab
/dev/acd0 /cdrom cd9660 ro,noauto 0 0
gdb shows:
Program terminated with signal 11, Segmentation fault.
#0 0x08049dd7 in build_iovec (iov=0xcdbfd834, iovlen=0xcdbfd838,
name=0x80bc060 "ro", val=0x0, len=4294967295)
at /usr/src/sbin/mount/getmntopts.c:159
159 len = strlen(val) + 1;
--
Maxim Konovalov
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051114175556.L71805>