Date: Wed, 17 Nov 2021 05:10:50 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Yasuhiro Kimura <yasu@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: bb8dbe1580ae - main - sysutils/lnav: Fix distinfo Message-ID: <YZSO2vNqqVOTRsfI@FreeBSD.org> In-Reply-To: <20211117.132859.1875579380149864513.yasu@FreeBSD.org> References: <YZR1/8m59hCb41l1@FreeBSD.org> <20211117.124452.1254944101155682425.yasu@utahime.org> <YZR95khRXDiLkMlD@FreeBSD.org> <20211117.132859.1875579380149864513.yasu@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 17, 2021 at 01:28:59PM +0900, Yasuhiro Kimura wrote: > ... > have no preference about it. I just keep what is written. So I'm just > confused to be complained about it to me. Kimura-san, I guess I shouldn't have concentrate on this DIST/PORT version thing which drove attention away from the main point, which is why gratuitous changes are pessimization and should be avoided (we'd also ignore the SNR issue for now). Previously, the Makefile reader would see the commit which updated the port to version 0.10.1 in the plain "git blame Makefile" output. Now, it's clobbered, so takes a "git blame bb8dbe1580ae0^ Makefile" to get the needed hash. Admittedly, you've done a good job providing enough details in the commit log, including the original update hash, but that does not happen all the time (most people are lazy), and does not relieve one of having to deal with incomprehensible git hashes (unlike small integer revisions we had before which could at least be recognized, if not memorized -- that helped with multi-level blaming a lot; now with git this is harder). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YZSO2vNqqVOTRsfI>