Date: Thu, 25 May 2006 08:08:25 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: glebius@FreeBSD.ORG Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/pccbb pccbb.c Message-ID: <20060525.080825.1649780628.imp@bsdimp.com> In-Reply-To: <20060525111035.GI27819@FreeBSD.org> References: <200605241726.k4OHQG59037586@repoman.freebsd.org> <20060525111035.GI27819@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20060525111035.GI27819@FreeBSD.org>
Gleb Smirnoff <glebius@FreeBSD.org> writes:
: On Wed, May 24, 2006 at 05:26:16PM +0000, Warner Losh wrote:
: W> imp 2006-05-24 17:26:16 UTC
: W>
: W> FreeBSD src repository
: W>
: W> Modified files:
: W> sys/dev/pccbb pccbb.c
: W> Log:
: W> Suspend the children before we turn off card events in hardware. This
: W> was done, I believe, to work around some cards having issues in the
: W> suspend case. I think that this helped my Sony VAIO TS505 work better
: W> when it had certain wireless cards in it and I did a apm -z. I've not
: ^^^^^^^
: W> tested suspend/resume on other laptops in a long time, so I hope this
: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
: W> doesn't cause greif. Please let me know if it does.
: ^^^^^^^^^^^^^^^^^^^
:
: Is this a joke, that I can't understand? :(
:
: This file has broken APM suspend since revision 1.122, which was made
: almost a year ago. I've told that several times, and I still hope that
: this will be fixed before RELENG_7. The problem is not in suspending
: children, since suspend is broken w/o any cards in slot. The problem is
: in DELAY -> tsleep() conversion. The latter is not working, when
: system is suspending.
The problem is elsewhere in the system if it is the use of tsleep.
Get me a laptop that has otherwise working suspend/resume and I'll fix
this.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060525.080825.1649780628.imp>