Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 24 Apr 2005 16:21:44 GMT
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 75890 for review
Message-ID:  <200504241621.j3OGLiHT092440@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=75890

Change 75890 by rwatson@rwatson_paprika on 2005/04/24 16:20:44

	Answer the question in the comment as to whether au_free_token()
	should be a macro -- answer is no, because it's a defined part of
	the API/ABI as a symbol, and in order to keep the contents of the
	token structure out of the ABI, it has to be a function.
	
	Minor reformatting.

Affected files ...

.. //depot/projects/trustedbsd/openbsm/libbsm/bsm_audit.c#4 edit

Differences ...

==== //depot/projects/trustedbsd/openbsm/libbsm/bsm_audit.c#4 (text+ko) ====

@@ -55,17 +55,16 @@
 
 /* 
  * This call frees a token_t and its internal data.  
- *
- * XXX  Should it be a macro for speed?  
  */
-void au_free_token(token_t *tok)
+void
+au_free_token(token_t *tok)
 {
-    if (tok)
-    {
+
+	if (tok != NULL) {
 		if (tok->t_data)
 			free(tok->t_data);
 		free(tok);
-    }
+	}
 }
 
 /*



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200504241621.j3OGLiHT092440>