Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 6 Jun 2025 22:17:40 GMT
From:      Brooks Davis <brooks@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 9623040eee15 - main - closefrom: always use close_range(2)
Message-ID:  <202506062217.556MHeM9025490@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by brooks:

URL: https://cgit.FreeBSD.org/src/commit/?id=9623040eee15b05b50b90b01da18537cce26a353

commit 9623040eee15b05b50b90b01da18537cce26a353
Author:     Brooks Davis <brooks@FreeBSD.org>
AuthorDate: 2025-06-06 21:13:29 +0000
Commit:     Brooks Davis <brooks@FreeBSD.org>
CommitDate: 2025-06-06 21:58:29 +0000

    closefrom: always use close_range(2)
    
    close_range(2) was added prior to 13.0.  There is no need to support
    a new userspace on such an old kernel.
    
    Reviewed by:    kevans, imp
    Differential Revision:  https://reviews.freebsd.org/D50730
---
 lib/libc/sys/closefrom.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/lib/libc/sys/closefrom.c b/lib/libc/sys/closefrom.c
index 292702fad38c..76ed4e744397 100644
--- a/lib/libc/sys/closefrom.c
+++ b/lib/libc/sys/closefrom.c
@@ -26,20 +26,12 @@
  */
 
 #include <sys/param.h>
-#include <sys/syscall.h>
 #include <unistd.h>
 
 #include "libc_private.h"
 
-#define	CLOSE_RANGE_OSREL		1300091
-
 void
 closefrom(int lowfd)
 {
-
-	if (__getosreldate() >= CLOSE_RANGE_OSREL)
-		__sys_close_range(MAX(0, lowfd), ~0U, 0);
-	else
-		/* Fallback to closefrom(2) on older kernels. */
-		syscall(SYS_freebsd12_closefrom, lowfd);
+	__sys_close_range(MAX(0, lowfd), ~0U, 0);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202506062217.556MHeM9025490>