Date: Mon, 9 Jan 2012 14:57:06 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Adrian Chadd <adrian@freebsd.org>, src-committers@freebsd.org, kmacy@FreeBSD.org Subject: Re: svn commit: r229800 - head/sys/conf Message-ID: <20120109135706.GE4117@garage.freebsd.pl> In-Reply-To: <201201090815.44495.jhb@freebsd.org> References: <201201080055.q080tMlJ063808@svn.freebsd.org> <20120108104330.GC1674@garage.freebsd.pl> <201201090815.44495.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--DqhR8hV3EnoxUkKN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 09, 2012 at 08:15:44AM -0500, John Baldwin wrote: > On Sunday, January 08, 2012 5:43:30 am Pawel Jakub Dawidek wrote: > > On Sun, Jan 08, 2012 at 12:55:22AM +0000, Adrian Chadd wrote: > > > Author: adrian > > > Date: Sun Jan 8 00:55:22 2012 > > > New Revision: 229800 > > > URL: http://svn.freebsd.org/changeset/base/229800 > > >=20 > > > Log: > > > Make these two files conditionally build on UFS_ACL, as it doesn't > > > seem to be used elsewhere. > > > =20 > > > Since UFS_ACL is enabled by default for GENERIC kernels, this shoul= dn't > > > break anything - but please beat me to fix things if it does. > >=20 > > If someone is actually using GENERIC kernel. This change will break all > > my system next time I upgrade. Adding UFS_ACL option to the kernel > > config to make ZFS kernel module to work doesn't sound very intuitive. > >=20 > > I understand what you are trying to accomplish, but we really need to > > find better way to do this. Until then, could you back it out? >=20 > Why not make 'options ZFS' work? Then you can have subr_acl_nfs.c depend= on > ZFS as well. At the time I looked at it, it was very hard (at least for me) to make it work. Note that initial import of ZFS was delayed, because of this very reason. Then des@ convinced me to go ahead with module-only solution. The problem with having ZFS compiled into the kernel is that OpenSolaris compatiblity layer needs its headers to be included before system headers, which is/was impossible or hard to express for kernel compilation. AFAIR Kip Macy was working on it and my understanding was that he finished it or almost finished it (CCed). I'm all for making ZFS be compilable as part of the kernel itself, but it is really very low on my list, because ZFS simply works now and also because as I said, it was far from trivial for me to do it. If someone who is more familiar with the bits responsible for kernel compilation wants to work on including ZFS there, I'll gladly provide help from the ZFS side. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --DqhR8hV3EnoxUkKN Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk8K8jIACgkQForvXbEpPzS+xQCdHONluQeEW7xhqhyUC3oE4+C9 pgcAoKmoV5lYXLTdjk51BApPCp8GkldE =e9Y2 -----END PGP SIGNATURE----- --DqhR8hV3EnoxUkKN--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120109135706.GE4117>