Date: Mon, 18 Sep 2017 17:05:40 +0200 From: Hans Petter Selasky <hps@selasky.org> To: Conrad Meyer <cem@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r323692 - in head/sys/compat: linsysfs linux Message-ID: <7527afaa-c983-a2dd-6a1c-a20bb1d03d7a@selasky.org> In-Reply-To: <201709172340.v8HNeGuP016998@repo.freebsd.org> References: <201709172340.v8HNeGuP016998@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 09/18/17 01:40, Conrad Meyer wrote:
> device_get_children(dev, &children, &nchildren);
> for (i = 0; i < nchildren; i++) {
> if (children[i])
> - linsysfs_run_bus(children[i], dir, scsi, new_path, prefix);
> + linsysfs_run_bus(children[i], dir, scsi, chardev, new_path, prefix);
> }
> if (new_path != path)
> free(new_path, M_TEMP);
> + free(chardevname, M_TEMP);
>
> return (1);
1) Return code from device_get_children() should be checked.
2) children pointer should be freed else there is a memory leak.
--HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7527afaa-c983-a2dd-6a1c-a20bb1d03d7a>