Date: Wed, 5 Jan 2022 16:18:25 -0700 From: Warner Losh <imp@bsdimp.com> To: Gleb Smirnoff <glebius@freebsd.org> Cc: Alexander Motin <mav@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: ce881170088c - main - atkbd: Disable periodic polling by default. Message-ID: <CANCZdfo0asGzvD=o_4WDih9FDCeOO7sz9SgqjhOb13RSDj%2B4mQ@mail.gmail.com> In-Reply-To: <YdYf67Wp5ofztN0r@FreeBSD.org> References: <202201052013.205KD3HJ024209@gitrepo.freebsd.org> <YdYf67Wp5ofztN0r@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000002f783e05d4ddf997 Content-Type: text/plain; charset="UTF-8" On Wed, Jan 5, 2022, 3:47 PM Gleb Smirnoff <glebius@freebsd.org> wrote: > On Wed, Jan 05, 2022 at 08:13:03PM +0000, Alexander Motin wrote: > A> commit ce881170088c4c98c036fe561f8ee8413c2e2585 > A> Author: Alexander Motin <mav@FreeBSD.org> > A> AuthorDate: 2022-01-05 20:00:36 +0000 > A> Commit: Alexander Motin <mav@FreeBSD.org> > A> CommitDate: 2022-01-05 20:12:58 +0000 > A> > A> atkbd: Disable periodic polling by default. > A> > A> It is one of the few remaining Giant-locked callouts. It would be > A> good to remove it, not mentioning that polling itself is not good. > A> > A> If this cause keyboard/mouse freezes on some hardware, please set > A> loader tunable hw.atkbd.hz=1 as workaround and report the issue. > A> > A> Submitted by: imp, jhb > > Lame question: this is related only to a keyboard plugged into PS/2, isn't > it? > Yes. I think this part of the code is only for "legacy" keyboards. I don't think mice are affected, but since both attach to the keyboard controller there is a tiny chance mice might be affected in some weird hardware... Warner > --0000000000002f783e05d4ddf997 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" = class=3D"gmail_attr">On Wed, Jan 5, 2022, 3:47 PM Gleb Smirnoff <<a href= =3D"mailto:glebius@freebsd.org">glebius@freebsd.org</a>> wrote:<br></div= ><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1= px #ccc solid;padding-left:1ex">On Wed, Jan 05, 2022 at 08:13:03PM +0000, A= lexander Motin wrote:<br> A> commit ce881170088c4c98c036fe561f8ee8413c2e2585<br> A> Author:=C2=A0 =C2=A0 =C2=A0Alexander Motin <mav@FreeBSD.org><br= > A> AuthorDate: 2022-01-05 20:00:36 +0000<br> A> Commit:=C2=A0 =C2=A0 =C2=A0Alexander Motin <mav@FreeBSD.org><br= > A> CommitDate: 2022-01-05 20:12:58 +0000<br> A> <br> A>=C2=A0 =C2=A0 =C2=A0atkbd: Disable periodic polling by default.<br> A>=C2=A0 =C2=A0 =C2=A0<br> A>=C2=A0 =C2=A0 =C2=A0It is one of the few remaining Giant-locked callou= ts.=C2=A0 It would be<br> A>=C2=A0 =C2=A0 =C2=A0good to remove it, not mentioning that polling its= elf is not good.<br> A>=C2=A0 =C2=A0 =C2=A0<br> A>=C2=A0 =C2=A0 =C2=A0If this cause keyboard/mouse freezes on some hardw= are, please set<br> A>=C2=A0 =C2=A0 =C2=A0loader tunable hw.atkbd.hz=3D1 as workaround and r= eport the issue.<br> A>=C2=A0 =C2=A0 =C2=A0<br> A>=C2=A0 =C2=A0 =C2=A0Submitted by:=C2=A0 =C2=A0imp, jhb<br> <br> Lame question: this is related only to a keyboard plugged into PS/2, isn= 9;t it?<br></blockquote></div></div><div dir=3D"auto"><br></div><div dir=3D= "auto">Yes. I think this part of the code is only for "legacy" ke= yboards. I don't think mice are affected, but since both attach to the = keyboard controller there is a tiny chance mice might be affected in some w= eird hardware...=C2=A0</div><div dir=3D"auto"><br></div><div dir=3D"auto">W= arner</div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote class= =3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd= ing-left:1ex"> </blockquote></div></div></div> --0000000000002f783e05d4ddf997--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfo0asGzvD=o_4WDih9FDCeOO7sz9SgqjhOb13RSDj%2B4mQ>