Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Sep 2025 11:54:25 GMT
From:      Kristof Provost <kp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 5e89648ee68e - main - pf tests: test fragment counters
Message-ID:  <202509151154.58FBsPZv025441@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by kp:

URL: https://cgit.FreeBSD.org/src/commit/?id=5e89648ee68e44d01d00d41d53b6934c604f8c50

commit 5e89648ee68e44d01d00d41d53b6934c604f8c50
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2025-08-21 08:10:08 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2025-09-15 09:32:35 +0000

    pf tests: test fragment counters
    
    Ensure that the fragmentation counters work as expected.
    
    Sponsored by:   Rubicon Communications, LLC ("Netgate")
---
 tests/sys/netpfil/pf/fragmentation_pass.sh | 67 ++++++++++++++++++++++++++++++
 1 file changed, 67 insertions(+)

diff --git a/tests/sys/netpfil/pf/fragmentation_pass.sh b/tests/sys/netpfil/pf/fragmentation_pass.sh
index 5deaba18301d..c749aac793ee 100644
--- a/tests/sys/netpfil/pf/fragmentation_pass.sh
+++ b/tests/sys/netpfil/pf/fragmentation_pass.sh
@@ -648,6 +648,72 @@ dummynet_fragmented_cleanup()
 	pft_cleanup
 }
 
+atf_test_case "counters" "cleanup"
+counters_head()
+{
+	atf_set descr 'Test fragment counters'
+	atf_set require.user root
+}
+
+counters_body()
+{
+	pft_init
+
+	epair=$(vnet_mkepair)
+	vnet_mkjail alcatraz ${epair}a
+
+	ifconfig ${epair}b inet 192.0.2.1/24 up
+	jexec alcatraz ifconfig ${epair}a 192.0.2.2/24 up
+
+	jexec alcatraz pfctl -e
+	pft_set_rules alcatraz \
+		"set reassemble yes" \
+		"pass keep state"
+
+	# All fragment counters are zero
+	counters=$(jexec alcatraz pfctl -si -v | grep -A 4 '^Fragments')
+	atf_check -s exit:0 -o match:"current entries[[:space:]]+0" \
+	    echo $counters
+	atf_check -s exit:0 -o match:"searches[[:space:]]+0" \
+	    echo $counters
+	atf_check -s exit:0 -o match:"inserts[[:space:]]+0" \
+	    echo $counters
+	atf_check -s exit:0 -o match:"removals[[:space:]]+0" \
+	    echo $counters
+
+	# They remain zero after we've seen non-fragmented traffic
+	atf_check -s exit:0 -o ignore \
+	    ping -c 1 192.0.2.2
+	counters=$(jexec alcatraz pfctl -si -v | grep -A 4 '^Fragments')
+	atf_check -s exit:0 -o match:"current entries[[:space:]]+0" \
+	    echo $counters
+	atf_check -s exit:0 -o match:"searches[[:space:]]+0" \
+	    echo $counters
+	atf_check -s exit:0 -o match:"inserts[[:space:]]+0" \
+	    echo $counters
+	atf_check -s exit:0 -o match:"removals[[:space:]]+0" \
+	    echo $counters
+
+	# But once we've reassembled they're no longer zero
+	# (Count is 2, because in + out)
+	atf_check -s exit:0 -o ignore \
+	    ping -c 1 -s 2000 192.0.2.2
+	counters=$(jexec alcatraz pfctl -si -v | grep -A 4 '^Fragments')
+	atf_check -s exit:0 -o match:"current entries[[:space:]]+0" \
+	    echo $counters
+	atf_check -s exit:0 -o match:"searches[[:space:]]+2" \
+	    echo $counters
+	atf_check -s exit:0 -o match:"inserts[[:space:]]+2" \
+	    echo $counters
+	atf_check -s exit:0 -o match:"removals[[:space:]]+2" \
+	    echo $counters
+}
+
+counters_cleanup()
+{
+	pft_cleanup
+}
+
 atf_init_test_cases()
 {
 	atf_add_test_case "too_many_fragments"
@@ -665,4 +731,5 @@ atf_init_test_cases()
 	atf_add_test_case "dummynet"
 	atf_add_test_case "dummynet_nat"
 	atf_add_test_case "dummynet_fragmented"
+	atf_add_test_case "counters"
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202509151154.58FBsPZv025441>