Date: Thu, 25 May 2017 22:53:19 +0200 From: Harry Schmalzbauer <freebsd@omnilan.de> To: Vincenzo Maffione <v.maffione@gmail.com> Cc: freebsd-net <freebsd-net@freebsd.org> Subject: Re: [panic] netmap(4) and if_lagg(4) Message-ID: <5927443F.8080502@omnilan.de> In-Reply-To: <592742A8.4010207@omnilan.de> References: <58CBCD7A.8060301@omnilan.de> <CA%2B_eA9iCT7evWUcZMA_ViKfrZnSHp3OpBTS5c4iJ9=ZjO-Pfgw@mail.gmail.com> <58CC23F5.7060507@omnilan.de> <CA%2B_eA9iajZOUFsnWKdodN7zMvst8wn0xViM4xxEx%2B41jw_0B3g@mail.gmail.com> <58CFA394.8070901@omnilan.de> <CA%2B_eA9jf_VjcYUZynu5CXx-ps5z7PSxOky=QLpR-miqtxmMU5w@mail.gmail.com> <5926EE96.1010000@omnilan.de> <CA%2B_eA9gcMD1QyG35p5UY8kz6n1kF%2B56Arz3q1T8HVBfMv3XN0w@mail.gmail.com> <5926F9F9.4040706@omnilan.de> <CA%2B_eA9hripEStmfJhj_Q93OF5jFf2nfQXeuA2DnuSjBmJi6j4g@mail.gmail.com> <592701D6.7030301@omnilan.de> <592742A8.4010207@omnilan.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Bezüglich Harry Schmalzbauer's Nachricht vom 25.05.2017 22:46 (localtime):
> Bezüglich Harry Schmalzbauer's Nachricht vom 25.05.2017 18:09 (localtime):
>> Bezüglich Vincenzo Maffione's Nachricht vom 25.05.2017 17:56 (localtime):
>>> I see the bug is in FreeBSD 11. I attached the simple patch to fix it.
>>> Can someone commit the patch to 11/stable?
>>>
>>> Harry: You should be able to workaround the bug by setting
>>>
>>> # sysctl dev.netmap.generic_rings=1
>> I'll recompile with your patch, thanks a lot!
> Hi, unfortunately I can't confirm it to be fixed.
>
> The kgdb output is exactly the same:
>
> (kgdb) list *0xffffffff80426714
> 0xffffffff80426714 is in generic_rx_handler
> (/usr/local/share/deploy-tools/RELENG_11/src/sys/dev/netmap/netmap_generic.c:628).
> 623 struct netmap_adapter *na = NA(ifp);
> 624 struct netmap_generic_adapter *gna = (struct
> netmap_generic_adapter *)na;
> 625 u_int work_done;
> 626 u_int rr = MBUF_RXQ(m); // receive ring number
> 627
> 628 if (rr >= na->num_rx_rings) {
> 629 rr = rr % na->num_rx_rings; // XXX expensive...
> 630 }
> 631
> 632 /* limit the size of the queue */
> Current language: auto; currently minimal
>
> Will double-check tomorrow that the binary really includes your patch.
> Ofcourse I checked briefly and revision and buildtime check affirms it.
Last note for today; late here:
The patch is against sys/dev/netmap/netmap_freebsd.c (at least my
interpretation of it, since f1.c wasN#t applicable), and the debugger
claims sys/dev/netmap/netmap_generic.c!
thnaks,
-harry
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5927443F.8080502>