Date: Thu, 16 Feb 2012 02:48:46 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Bruce Evans <brde@optusnet.com.au> Subject: Re: svn commit: r231760 - head/sys/netgraph Message-ID: <20120216023627.D3142@besplex.bde.org> In-Reply-To: <20120215152729.GQ20404@FreeBSD.org> References: <201202151426.q1FEQpn7065868@svn.freebsd.org> <20120216015919.X2940@besplex.bde.org> <20120215152729.GQ20404@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 15 Feb 2012, Gleb Smirnoff wrote: > On Thu, Feb 16, 2012 at 02:19:37AM +1100, Bruce Evans wrote: > B> systm was already sorted. Like param.h, it defines important macros that > ... > is this patch okay? Yes. > I'd prefer to leave sys/queue.h included explicitly. Yes, there is nothing better. sys/queue.h is now referenced 926 times in .depend for a kernel with 951 object files. This is more references than even for sys/param.h (901). This shows that sys/queue.h might as well be standard pollution. But hopefully, lots of the dependencies on queue.h are not real ones, but are the result of other pollution which might be cleanable. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120216023627.D3142>