Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 1 Jun 2025 14:48:29 GMT
From:      Zhenlei Huang <zlei@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 517eb20e54e5 - main - if_firewire: Make firewire_broadcastaddr static const
Message-ID:  <202506011448.551EmTSN053153@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by zlei:

URL: https://cgit.FreeBSD.org/src/commit/?id=517eb20e54e59173b9dbede0bb3356f6197b5aa9

commit 517eb20e54e59173b9dbede0bb3356f6197b5aa9
Author:     Zhenlei Huang <zlei@FreeBSD.org>
AuthorDate: 2025-06-01 14:47:24 +0000
Commit:     Zhenlei Huang <zlei@FreeBSD.org>
CommitDate: 2025-06-01 14:47:24 +0000

    if_firewire: Make firewire_broadcastaddr static const
    
    This global variable is used only in this file. While here, constify it
    since it is only used to read.
    
    No functional change intended.
    
    MFC after:      1 week
---
 sys/net/if_fwsubr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/net/if_fwsubr.c b/sys/net/if_fwsubr.c
index bf3362fc975c..ceac93d31d56 100644
--- a/sys/net/if_fwsubr.c
+++ b/sys/net/if_fwsubr.c
@@ -67,7 +67,7 @@
 
 static MALLOC_DEFINE(M_FWCOM, "fw_com", "firewire interface internals");
 
-struct fw_hwaddr firewire_broadcastaddr = {
+static const struct fw_hwaddr firewire_broadcastaddr = {
 	0xffffffff,
 	0xffffffff,
 	0xff,
@@ -777,7 +777,7 @@ firewire_ifattach(struct ifnet *ifp, struct fw_hwaddr *llc)
 	ifp->if_mtu = 1500;	/* XXX */
 	ifp->if_output = firewire_output;
 	ifp->if_resolvemulti = firewire_resolvemulti;
-	ifp->if_broadcastaddr = (u_char *) &firewire_broadcastaddr;
+	ifp->if_broadcastaddr = (const u_char *) &firewire_broadcastaddr;
 
 	ifa = ifp->if_addr;
 	KASSERT(ifa != NULL, ("%s: no lladdr!\n", __func__));



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202506011448.551EmTSN053153>