Date: Thu, 27 Apr 2017 17:39:34 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 218919] setsockopt() accepts too long arguments allowing programmer errors Message-ID: <bug-218919-2472@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218919 Bug ID: 218919 Summary: setsockopt() accepts too long arguments allowing programmer errors Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: freebsd-net@FreeBSD.org Reporter: brooks@FreeBSD.org When a programmer mistakenly passes a size_t to a setsockopt() command that takes an int, the sooptcopyin() function ignores the extra size. On little-endian systems, the result works anyway. On big-endian systems the wrong bits of the size get copied resulting in failure. An example of this= can be seen in https://reviews.freebsd.org/D10518. Due to the use of unions as arguments to some setsockopt() commands, it is somewhat clear why sooptcopyin() takes a length and minlength. It's less c= lear to me that over-length parameters should be allowed and in the case of int/size_t confusion the current behavior is just wrong. https://reviews.freebsd.org/D10519 contains one possible partial fix, but I think a larger sweep is required and something more like a sooptcopyin_exac= t() might be a better approach. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-218919-2472>