Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 2 Nov 2022 16:35:28 +0000
From:      Doug Rabson <dfr@rabson.org>
To:        Kyle Evans <kevans@freebsd.org>
Cc:        Guido Falsi <mad@madpilot.net>, freebsd-pkgbase@freebsd.org
Subject:   Re: New conflict on if_wg.h in runtime package
Message-ID:  <CACA0VUhaTJQX8FjL3gc9U7U2k62vZa%2BrGtMkKm=YWoAX_oWWHA@mail.gmail.com>
In-Reply-To: <CACNAnaHW%2Bn2ZjZZsQmknxSAXcp4a=xdsCEhR5L0fRUOw8gFwrA@mail.gmail.com>
References:  <edc66854-7f9e-9383-643a-7ffb76b60890@madpilot.net> <CACA0VUiU8zvWgiwcUs8-sg6PmcQiMGGu-1v8j0HBGQPj2_VFzA@mail.gmail.com> <c1e4cdb7-51b0-7a6b-7ada-fd22cb8d94f7@madpilot.net> <CACA0VUhU2NjaU=tJhvXqcrO0%2BBcgSA_cGrkeYTy3upKzucw1uQ@mail.gmail.com> <CACNAnaHW%2Bn2ZjZZsQmknxSAXcp4a=xdsCEhR5L0fRUOw8gFwrA@mail.gmail.com>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
On Wed, 2 Nov 2022 at 16:30, Kyle Evans <kevans@freebsd.org> wrote:

> On Wed, Nov 2, 2022 at 11:21 AM Doug Rabson <dfr@rabson.org> wrote:
> >
> >
> >
> > On Wed, 2 Nov 2022 at 16:07, Guido Falsi <mad@madpilot.net> wrote:
> >>
> >> On 02/11/22 16:32, Doug Rabson wrote:
> >> >
> >> >
> >> > On Wed, 2 Nov 2022 at 13:54, Guido Falsi <mad@madpilot.net
> >> > <mailto:mad@madpilot.net>> wrote:
> >> >
> >> >     Hi!
> >> >
> >> >     I am trying to upgrade head using packaged base and I'm getting
> this
> >> >     error now:
> >> >
> >> >     pkg: FreeBSD-runtime-dev-14.snap20221102095743 conflicts with
> >> >     FreeBSD-runtime-14.snap20221102095743 (installs files into the
> same
> >> >     place).  Problematic file: /usr/include/dev/wg/if_wg.h
> >> >
> >> >     Looks like for some reason if_wg.h ended up in both packages.
> >> >
> >> >     Am I doing something wrong and can I work around this or should
> this be
> >> >     fixed in the sources?
> >> >
> >> >
> >> > This seems to be a problem in pkgbase. Packages are built using the
> >> > metalog generated from the various install commands during the build -
> >> > if_wg.h has two entries in the metalog, one with
> >> > tags=package=runtime,dev and one with tags=package=runtime. Can you
> open
> >> > a bug on bugs.freebsd.org <http://bugs.freebsd.org>?
> >> >
> >> >
> >>
> >>
> >> sure!
> >
> >
> > I think the problem is caused by the 'copies' target in src/include
> which is where the second metalog entry happens. From my limited
> understanding, this target shouldn't create metalog entries but I'm not
> sure how to stop it.
> >>
>
> It's via ${INSTALL}, which uses ${INSTALLFLAGS} that includes metalog
> bits. The problem is we're using the global ${TAG_ARGS} for those, but
> that's wrong on a number of levels. All of the headers need, at a
> minimum, a version of ${TAG_ARGS} that has ,dev, but also a lot of
> these have their own *PACKAGE that they should go to instead.
>

That makes sense - for if_wg.h, there is an explicit entry in the WG group
which does get installed with ,dev.

[-- Attachment #2 --]
<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 2 Nov 2022 at 16:30, Kyle Evans &lt;<a href="mailto:kevans@freebsd.org">kevans@freebsd.org</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">On Wed, Nov 2, 2022 at 11:21 AM Doug Rabson &lt;<a href="mailto:dfr@rabson.org" target="_blank">dfr@rabson.org</a>&gt; wrote:<br>
&gt;<br>
&gt;<br>
&gt;<br>
&gt; On Wed, 2 Nov 2022 at 16:07, Guido Falsi &lt;<a href="mailto:mad@madpilot.net" target="_blank">mad@madpilot.net</a>&gt; wrote:<br>
&gt;&gt;<br>
&gt;&gt; On 02/11/22 16:32, Doug Rabson wrote:<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; On Wed, 2 Nov 2022 at 13:54, Guido Falsi &lt;<a href="mailto:mad@madpilot.net" target="_blank">mad@madpilot.net</a><br>
&gt;&gt; &gt; &lt;mailto:<a href="mailto:mad@madpilot.net" target="_blank">mad@madpilot.net</a>&gt;&gt; wrote:<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;     Hi!<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;     I am trying to upgrade head using packaged base and I&#39;m getting this<br>
&gt;&gt; &gt;     error now:<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;     pkg: FreeBSD-runtime-dev-14.snap20221102095743 conflicts with<br>
&gt;&gt; &gt;     FreeBSD-runtime-14.snap20221102095743 (installs files into the same<br>
&gt;&gt; &gt;     place).  Problematic file: /usr/include/dev/wg/if_wg.h<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;     Looks like for some reason if_wg.h ended up in both packages.<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;     Am I doing something wrong and can I work around this or should this be<br>
&gt;&gt; &gt;     fixed in the sources?<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; This seems to be a problem in pkgbase. Packages are built using the<br>
&gt;&gt; &gt; metalog generated from the various install commands during the build -<br>
&gt;&gt; &gt; if_wg.h has two entries in the metalog, one with<br>
&gt;&gt; &gt; tags=package=runtime,dev and one with tags=package=runtime. Can you open<br>
&gt;&gt; &gt; a bug on <a href="http://bugs.freebsd.org" rel="noreferrer" target="_blank">bugs.freebsd.org</a> &lt;<a href="http://bugs.freebsd.org" rel="noreferrer" target="_blank">http://bugs.freebsd.org</a>&gt;?<br>;
&gt;&gt; &gt;<br>
&gt;&gt; &gt;<br>
&gt;&gt;<br>
&gt;&gt;<br>
&gt;&gt; sure!<br>
&gt;<br>
&gt;<br>
&gt; I think the problem is caused by the &#39;copies&#39; target in src/include which is where the second metalog entry happens. From my limited understanding, this target shouldn&#39;t create metalog entries but I&#39;m not sure how to stop it.<br>
&gt;&gt;<br>
<br>
It&#39;s via ${INSTALL}, which uses ${INSTALLFLAGS} that includes metalog<br>
bits. The problem is we&#39;re using the global ${TAG_ARGS} for those, but<br>
that&#39;s wrong on a number of levels. All of the headers need, at a<br>
minimum, a version of ${TAG_ARGS} that has ,dev, but also a lot of<br>
these have their own *PACKAGE that they should go to instead.<br></blockquote><div><br></div><div>That makes sense - for if_wg.h, there is an explicit entry in the WG group which does get installed with ,dev. <br></div></div></div>
help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACA0VUhaTJQX8FjL3gc9U7U2k62vZa%2BrGtMkKm=YWoAX_oWWHA>