Date: Sun, 30 Dec 2007 22:50:30 +0100 (CET) From: Gerald Pfeifer <gerald@pfeifer.com> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/emulators/wine Makefile Message-ID: <Pine.LNX.4.64.0712302234340.25278@acrux.dbai.tuwien.ac.at> In-Reply-To: <20071230101717.GA34181@FreeBSD.org> References: <200712291927.lBTJRRwj081521@repoman.freebsd.org> <20071230101717.GA34181@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
On Sun, 30 Dec 2007, Alexey Dokuchaev wrote:
>> Log:
>> Add cups-base as a library dependency.
> Why not simply make it OPTIONal? I really don't want to have any cups
> bits and pieces on my system. Why wine wants cups, BTW?
>
> If you'd like, I can prepare patch for you with all additional deps
> mentioned in PR as OPTIONS.
Thanks for the offer, Alexey, very much appreciated!
>From the feedback I have received in the last 24 hours it seems clear
we'll want to make the cups-base dependency OPTIONal, and adding some
others like LDAP or possibly SANE also sound possibly useful. ISDN/
libcapi support probably is something we can do without, but it probably
doesn't hurt either. ;-)
We just got another PR which mostly is a duplicate on the one you
referred to (ports/117627), and based on your kind offer I'll assign
that one (ports/119155) to you in a minute. I'm looking forward to
your patch -- the attached one by Tijl Coosemans <tijl@ulyssis.org>
might provide a bit of inspiration (the libjpeg part is obsolete).
Gerald
[-- Attachment #2 --]
--- Makefile.orig 2007-07-04 18:38:17.000000000 +0200
+++ Makefile 2007-07-04 18:38:20.000000000 +0200
@@ -52,6 +52,31 @@
IGNORE= fails to work on versions of FreeBSD before 5.3 (due to problems with threading support)
.endif
+.if defined(WITH_CUPS) || exists(${LOCALBASE}/lib/libcups.so.2)
+LIB_DEPENDS+= cups.2:${PORTSDIR}/print/cups-base
+.endif
+
+.if defined(WITH_HAL) || exists(${LOCALBASE}/lib/libhal.so.1)
+LIB_DEPENDS+= dbus-1.3:${PORTSDIR}/devel/dbus \
+ hal.1:${PORTSDIR}/sysutils/hal
+.endif
+
+.if defined(WITH_LIBGPHOTO2) || exists(${LOCALBASE}/lib/libgphoto2.so.2)
+LIB_DEPENDS+= gphoto2.2:${PORTSDIR}/graphics/libgphoto2
+.endif
+
+.if defined(WITH_JPEG) || exists(${LOCALBASE}/lib/libjpeg.so.9)
+LIB_DEPENDS+= jpeg.9:${PORTSDIR}/graphics/jpeg
+.endif
+
+.if defined(WITH_OPENLDAP) || exists(${LOCALBASE}/lib/libldap_r.so)
+USE_OPENLDAP= yes
+.endif
+
+.if defined(WITH_SANE) || exists(${LOCALBASE}/lib/libsane.so.1)
+LIB_DEPENDS+= sane.1:${PORTSDIR}/graphics/sane-backends
+.endif
+
pre-build:
cd ${WRKSRC} && make depend
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.LNX.4.64.0712302234340.25278>