Date: Tue, 25 Apr 2006 13:43:58 -0600 From: Scott Long <scottl@samsco.org> To: John Baldwin <jhb@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/bce if_bcereg.h Message-ID: <444E7BFE.4040800@samsco.org> In-Reply-To: <200604251540.00170.jhb@freebsd.org> References: <200604251918.k3PJImQA007820@repoman.freebsd.org> <444E7750.206@samsco.org> <200604251540.00170.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote: > On Tuesday 25 April 2006 15:24, Scott Long wrote: > >>John Baldwin wrote: >> >>>jhb 2006-04-25 19:18:48 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/dev/bce if_bcereg.h >>> Log: >>> Fix half of the current i386 tinderbox failure. max_bus_addr should be a >>> bus_addr_t rather than a bus_size_t. >>> >>> Revision Changes Path >>> 1.2 +1 -1 src/sys/dev/bce/if_bcereg.h >> >>Actually, bus_size_t should also be aware of PAE. > > > That may be true as well, I'll defer to your judgement on that one. In > this case bus_dma_tag_create()'s low_addr argument is supposed to be a > bus_addr_t according to the man page. :) > Both the lowaddr and highaddr arguments are bus_addr_t. The more I think about it, the boundary argument should really be a bus_addr_t. Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?444E7BFE.4040800>