Date: Thu, 09 Oct 2025 19:41:22 +0200 From: "Christos Margiolis" <christos@freebsd.org> To: "Mark Johnston" <markj@freebsd.org> Cc: =?utf-8?q?Dag-Erling_Sm=C3=B8rgrav?= <des@freebsd.org>, <src-committers@freebsd.org>, <dev-commits-src-all@freebsd.org>, <dev-commits-src-main@freebsd.org>, <0mp@freebsd.org> Subject: Re: git: 9cab9fde5eda - main - virtual_oss: Port to base Message-ID: <DDDZ5T1KC0OJ.1CDQG7R5MCJ05@freebsd.org> In-Reply-To: <aOUfS4Awjipn5sN8@nuc> References: <202509280958.58S9wrww083342@gitrepo.freebsd.org> <861pnf83kw.fsf@ltc.des.dev> <DDC4YD5DFUJG.3U2A4JZJD1ZRV@FreeBSD.org> <aOUfS4Awjipn5sN8@nuc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue Oct 7, 2025 at 4:10 PM CEST, Mark Johnston wrote: > On Tue, Oct 07, 2025 at 03:48:26PM +0200, Christos Margiolis wrote: >> On Tue Oct 7, 2025 at 11:26 AM CEST, Dag-Erling Sm=C3=B8rgrav wrote: >> > Christos Margiolis <christos@FreeBSD.org> writes: >> >> libexec/rc/rc.d/virtual_oss | 119 + >> > >> > This contains a reference to a non-existent sndiod service. >>=20 >> I am aware. I discussed this with 0mp@ during EuroBSDCon in Zagreb and >> decided that it probably does not hurt too much to leave it there, at >> least for now. > > Well, it'll break the test added in https://reviews.freebsd.org/D52954, > which will be useful for catching bugs. If I understand correctly, the test is meant to catch dependency cycles? If yes, why would we have one here? >> It's important to note that for most users sndiod actually is not >> needed. This is only needed when virtual_oss(8) runs with sndio support, >> which has been moved to a new port: audio/virtual_oss_sndio. > > Why not just modify the sndiod script to REQUIRE virtual_oss? Why REQUIRE and not BEFORE? virtual_oss is not *required* for sndiod to run, and vice-versa. sndiod is required by virtual_oss(8) only when virtual_oss(8) wants to use sndio devices. Christos
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DDDZ5T1KC0OJ.1CDQG7R5MCJ05>