Date: Mon, 11 Sep 2023 01:53:55 -0700 From: Mark Millard <marklmi@yahoo.com> To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@FreeBSD.org> Cc: Warner Losh <imp@bsdimp.com>, Martin Matuska <mm@freebsd.org>, Alexander Motin <mav@freebsd.org>, Pawel Jakub Dawidek <pjd@freebsd.org>, Glen Barber <gjb@freebsd.org>, Mike Karels <mike@karels.net>, Current FreeBSD <freebsd-current@freebsd.org>, FreeBSD-STABLE Mailing List <freebsd-stable@freebsd.org>, freebsd-arm <freebsd-arm@freebsd.org> Subject: Re: Looks like the kyua zfs tests likely are not used on aarch64 or other contexts with unsigned char Message-ID: <20C7F20D-8458-4BDE-9E66-F12CD5F2C230@yahoo.com> In-Reply-To: <16DE542C-D0D1-473A-B1BB-64A732265EC7@yahoo.com> References: <96C2F8F3-D3F0-48FC-BEEC-E3C983BD680A@yahoo.com> <DF839928-F06A-4F0A-8C3B-CAC97060D1CB@yahoo.com> <CANCZdfo5YwOdR7d0DNkf_VJ-wq4R=OVN=zafecShFLoA58qYJQ@mail.gmail.com> <FAB697B1-84BE-417F-AF09-ABF97194D422@yahoo.com> <86wmwxp57p.fsf@ltc.des.no> <16DE542C-D0D1-473A-B1BB-64A732265EC7@yahoo.com>
index | next in thread | previous in thread | raw e-mail
On Sep 11, 2023, at 00:03, Mark Millard <marklmi@yahoo.com> wrote: > On Sep 10, 2023, at 23:57, Dag-Erling Smørgrav <des@FreeBSD.org> wrote: > >> Mark Millard <marklmi@yahoo.com> writes: >>> I'm not aware of there being other documentation for what >>> is appropriate for setting up such for kyua runs. >> >> https://github.com/freebsd/freebsd-ci/blob/master/scripts/build/build-test_image-head.sh#L69-L84 >> > > Thanks for the reference that does not involve looking at > CI log files. Filed away for future references. > > > Side note . . . > > Turns out that tcptestsuite does not build for aarch64 > do to alignment problems via packing in net/packetdrill : > > In file included from run_packet.c:45: > In file included from ./tcp_options_iterator.h:31: > ./tcp_options.h:108:2: error: field within 'struct tcp_option' is less aligned than 'union tcp_option::(anonymous at ./tcp_options.h:108:2)' and is usually due to 'struct tcp_option' being packed, which can lead to unaligned accesses [-Werror,-Wunaligned-access] > union { > ^ > --- sctp_iterator.o --- > cc -O2 -pipe -mcpu=cortex-a7 Looks like I messed up and reported an armv7 context. aarch64 built net/packetdrill and net/tcptestsuite just fine. Sorry for the noise. > -Wno-deprecated -g -fstack-protector-strong -fno-strict-aliasing -mcpu=cortex-a7 -Wall -Werror -g -c sctp_iterator.c -o sctp_iterator.o > --- tcp_options.o --- > cc -O2 -pipe -mcpu=cortex-a7 -Wno-deprecated -g -fstack-protector-strong -fno-strict-aliasing -mcpu=cortex-a7 -Wall -Werror -g -c tcp_options.c -o tcp_options.o > --- run_packet.o --- > 1 error generated. > *** [run_packet.o] Error code 1 > > make[1]: stopped in /wrkdirs/usr/ports/net/packetdrill/work/packetdrill-aebdc35/gtests/net/packetdrill > --- tcp_options.o --- > In file included from tcp_options.c:25: > ./tcp_options.h:108:2: error: field within 'struct tcp_option' is less aligned than 'union tcp_option::(anonymous at ./tcp_options.h:108:2)' and is usually due to 'struct tcp_option' being packed, which can lead to unaligned accesses [-Werror,-Wunaligned-access] > union { > ^ > 1 error generated. > *** [tcp_options.o] Error code 1 > > make[1]: stopped in /wrkdirs/usr/ports/net/packetdrill/work/packetdrill-aebdc35/gtests/net/packetdrill > 2 errors > === Mark Millard marklmi at yahoo.comhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20C7F20D-8458-4BDE-9E66-F12CD5F2C230>