Date: Sun, 27 Jun 2004 18:09:59 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: FreeBSD current users <current@freebsd.org> Subject: Re: jail getfsstat patches. Message-ID: <20040627160959.GL12007@darkness.comp.waw.pl> In-Reply-To: <Pine.BSF.4.53.0406271521050.89503@e0-0.zab2.int.zabbadoz.net> References: <Pine.BSF.4.21.0406251809530.1679-100000@InterJet.elischer.org> <20040627065932.GH12007@darkness.comp.waw.pl> <20040627101951.GJ12007@darkness.comp.waw.pl> <Pine.BSF.4.53.0406271521050.89503@e0-0.zab2.int.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--8tpUGmYwaewiPhBZ
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sun, Jun 27, 2004 at 03:53:35PM +0000, Bjoern A. Zeeb wrote:
+> One thing that I have seen while skipping through the first time:
+>=20
+> could we avoid the function calls for non-jails or with
+> jail_enforce_statfs=3D0 ? This would make the code somewhat longer
+> as this part would be copied over multiple functions
+>=20
+> if (jailed(cred) && jail_enforce_statfs) {
+> /* call of the two functions */
+> }
+>=20
+> (perhaps use a macro ?) but save people outside jails, w/o jails
+> or with jail_enforce_statfs=3D0 the function calls.
IMHO it should stay as it is, because:
- Some other prison_* functions do the same, i.e. check jailed(cred)
by themselfs.
- Function prison_canseemount() should be renamed some day to
cr_canseemount(), so I don't want it to be treated as jail-specific.
- Code is much cleaner.
- It doesn't save as too much CPU, really, and we don't need speed here.
+> To answer another question: though I maybe thought/said s.th. else in
+> the past I would like to keep the sysctl global and not have it per
+> jail (if we start doing per-jail things we might really consider
+> vimages (perhaps in 6-CURRENT) but that's out of the scope of
+> this discussion).
I agree, it shouldn't be per-jail. More than that, it should be removed
in the future to don't allow for old behaviour.
--=20
Pawel Jakub Dawidek http://www.FreeBSD.org
pjd@FreeBSD.org http://garage.freebsd.pl
FreeBSD committer Am I Evil? Yes, I Am!
--8tpUGmYwaewiPhBZ
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFA3vFXForvXbEpPzQRAkZ3AKCe1/9IBgc3alTPl+T7uDSkCT1GWACfUhhY
2lVdh8PfoLkm78X2PSvo5jU=
=Up9C
-----END PGP SIGNATURE-----
--8tpUGmYwaewiPhBZ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040627160959.GL12007>