Date: Sat, 18 Aug 2012 08:58:58 +1000 From: Peter Jeremy <peter@rulingia.com> To: John Baldwin <jhb@freebsd.org> Cc: freebsd-net@freebsd.org, Yuri <yuri@rawbw.com> Subject: Re: System doesn't detect unplugged network cable and doesn't set interface up properly with DHCP Message-ID: <20120817225857.GA2377@server.rulingia.com> In-Reply-To: <201208171148.17427.jhb@freebsd.org> References: <4FFF3683.7020107@rawbw.com> <500066F4.2030102@rawbw.com> <20120815003151.GF33399@server.rulingia.com> <201208171148.17427.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--vkogqOf2sHV7VnPd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2012-Aug-17 11:48:17 -0400, John Baldwin <jhb@freebsd.org> wrote: >Hmm, I think I see the issue. It doesn't export the existing lease info to >the script when running the FAIL action. I just tested this change and it >removed the old IP on my laptop when I tested it just now. I did some investigating during the week and came to pretty much the same patch. But the existing "don't remove an existing address" behaviour looked like a design decision and I went digging to find exactly what ip->client->active represented - and, in particular, whether in could represent an address that dhclient hadn't added to the interface. I did find that it could be read from the leases file but didn't have time to fully work through the code. If you're happy that this patch can't incorrectly remove a pre-existing IP address (I'm now reasonably confident that it can't), then I'm happy that it otherwise works. --=20 Peter Jeremy --vkogqOf2sHV7VnPd Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlAuzLEACgkQ/opHv/APuIcVCwCdHHXkED/9grC9nVGSLd5Wegna 58gAnAgRA3vCw2EE+LNi0V8rViel3fvv =zytO -----END PGP SIGNATURE----- --vkogqOf2sHV7VnPd--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120817225857.GA2377>