Skip site navigation (1)Skip section navigation (2) 
Date:      Sun, 27 Mar 2011 16:29:28 -0600
From:      Warner Losh <imp@bsdimp.com>
To:        Doug Barton <dougb@FreeBSD.org>
Cc:        Josh Paetzel <jpaetzel@FreeBSD.org>, svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, kib@FreeBSD.org
Subject:   Re: svn commit: r220059 - head/usr.sbin/pc-sysinstall/backend
Message-ID:  <EB25EDF1-9904-4329-9E52-6F3F122754A9@bsdimp.com>
In-Reply-To: <4D8F7257.50207@FreeBSD.org>
References:  <201103271657.p2RGvs2m063692@svn.freebsd.org> <4D8F7257.50207@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail 


On Mar 27, 2011, at 11:22 AM, Doug Barton wrote:

> On 03/27/2011 09:57, Josh Paetzel wrote:
>>   Replace "$?" = "0" with $? -eq 0 in tests
> 
> Excellent!

Most of the time I've found that moving the command up to the if makes the code clearer too.  At jobs I've had in the past when I've written code similar to what we have here, it almost always got flagged...

Warner
help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EB25EDF1-9904-4329-9E52-6F3F122754A9>