Date: Mon, 03 Aug 2020 11:06:59 -0700 From: Ravi Pokala <rpokala@freebsd.org> To: Peter Grehan <grehan@FreeBSD.org>, <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org> Subject: Re: svn commit: r363733 - head/usr.sbin/bhyve Message-ID: <F62ADDBD-5F6B-4D22-B2D0-E165B9C2C2B8@panasas.com> In-Reply-To: <202007311210.06VCATN9057871@repo.freebsd.org> References: <202007311210.06VCATN9057871@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----Original Message-----
From: <owner-src-committers@freebsd.org> on behalf of Peter Grehan <grehan@FreeBSD.org>
Date: 2020-07-31, Friday at 05:10
To: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org>
Subject: svn commit: r363733 - head/usr.sbin/bhyve
Author: grehan
Date: Fri Jul 31 12:10:28 2020
New Revision: 363733
URL: https://svnweb.freebsd.org/changeset/base/363733
Log:
Replace magic numbers in Identify page register 0 with ATA definitions.
No functional change. Verified with objdump output before/after.
Requested by: rpokala
Reviewed by: rpokala
MFC after: 3 weeks
Thanks! :-)
-Ravi (rpokala@)
Modified:
head/usr.sbin/bhyve/pci_ahci.c
Modified: head/usr.sbin/bhyve/pci_ahci.c
==============================================================================
--- head/usr.sbin/bhyve/pci_ahci.c Fri Jul 31 12:09:59 2020 (r363732)
+++ head/usr.sbin/bhyve/pci_ahci.c Fri Jul 31 12:10:28 2020 (r363733)
@@ -999,7 +999,8 @@ ata_identify_init(struct ahci_port* p, int atapi)
struct ata_params* ata_ident = &p->ata_ident;
if (atapi) {
- ata_ident->config = (2 << 14 | 5 << 8 | 1 << 7 | 2 << 5);
+ ata_ident->config = ATA_PROTO_ATAPI | ATA_ATAPI_TYPE_CDROM |
+ ATA_ATAPI_REMOVABLE | ATA_DRQ_FAST;
ata_ident->capabilities1 = ATA_SUPPORT_LBA |
ATA_SUPPORT_DMA;
ata_ident->capabilities2 = (1 << 14 | 1);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F62ADDBD-5F6B-4D22-B2D0-E165B9C2C2B8>