Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 27 Mar 2026 12:12:37 +0000
From:      Pouria Mousavizadeh Tehrani <pouria@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Cc:        K Rin <rin@sandb0x.tw>
Subject:   git: 18ce9e2dd0e0 - main - tests/netlink: Bugfix on snl_parse_errmsg_capped test
Message-ID:  <69c67435.40900.3c7ee0a2@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by pouria:

URL: https://cgit.FreeBSD.org/src/commit/?id=18ce9e2dd0e062583080da624499927e8df8eaf3

commit 18ce9e2dd0e062583080da624499927e8df8eaf3
Author:     K Rin <rin@sandb0x.tw>
AuthorDate: 2025-04-12 05:41:35 +0000
Commit:     Pouria Mousavizadeh Tehrani <pouria@FreeBSD.org>
CommitDate: 2026-03-27 12:01:06 +0000

    tests/netlink: Bugfix on snl_parse_errmsg_capped test
    
    Turn off the NETLINK_EXT_ACK flag to fix bug of snl_parse_errmsg_capped.
    
    Reviewed by:    pouria
    Pull Request:   https://github.com/freebsd/freebsd-src/pull/1660
---
 tests/sys/netlink/test_snl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/sys/netlink/test_snl.c b/tests/sys/netlink/test_snl.c
index 3990aa0b075d..c2bbc4aff949 100644
--- a/tests/sys/netlink/test_snl.c
+++ b/tests/sys/netlink/test_snl.c
@@ -64,11 +64,11 @@ ATF_TC_BODY(snl_parse_errmsg_capped, tc)
 	if (!snl_init(&ss, NETLINK_ROUTE))
 		atf_tc_fail("snl_init() failed");
 
-	atf_tc_skip("does not work");
-
 	int optval = 1;
 	ATF_CHECK(setsockopt(ss.fd, SOL_NETLINK, NETLINK_CAP_ACK, &optval, sizeof(optval)) == 0);
 
+	optval = 0;
+	ATF_CHECK(setsockopt(ss.fd, SOL_NETLINK, NETLINK_EXT_ACK, &optval, sizeof(optval)) == 0);
 	snl_init_writer(&ss, &nw);
 
 	struct nlmsghdr *hdr = snl_create_msg_request(&nw, 255);


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69c67435.40900.3c7ee0a2>