Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 5 Sep 2025 22:57:24 +0100
From:      Nuno Teixeira <eduardo@freebsd.org>
To:        Colin Percival <cperciva@freebsd.org>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org,  dev-commits-src-main@freebsd.org
Subject:   Re: git: af60084978a4 - main - Add description for WITH_PTHREADS_ASSERTIONS
Message-ID:  <CAFDf7UKymJ_3YefuHzO6ri=_GU44PcDZEQKSmGoMrmrBmxdttw@mail.gmail.com>
In-Reply-To: <202509052136.585La5mx020210@gitrepo.freebsd.org>
References:  <202509052136.585La5mx020210@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]
Hello Colin,

For people that turn off debug on main, should WITH_PTHREADS_ASSERTIONS be
turned off?

e.g.
/etc/src.conf:
WITH_MALLOC_PRODUCTION=yes
WITHOUT_LLVM_ASSERTIONS=yes

Thanks,

Colin Percival <cperciva@freebsd.org> escreveu (sexta, 5/09/2025 à(s)
22:36):

> The branch main has been updated by cperciva:
>
> URL:
> https://cgit.FreeBSD.org/src/commit/?id=af60084978a43632c5ab2d6e3aca41be7a658d8c
>
> commit af60084978a43632c5ab2d6e3aca41be7a658d8c
> Author:     Colin Percival <cperciva@FreeBSD.org>
> AuthorDate: 2025-09-05 21:29:51 +0000
> Commit:     Colin Percival <cperciva@FreeBSD.org>
> CommitDate: 2025-09-05 21:35:53 +0000
>
>     Add description for WITH_PTHREADS_ASSERTIONS
>
>     This option is turned on by default in -CURRENT but will be turned off
>     in 15-STABLE; this description will land in the src.conf(5) man page
>     in that branch.
>
>     MFC after:      1 minute
> ---
>  tools/build/options/WITH_PTHREADS_ASSERTIONS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/build/options/WITH_PTHREADS_ASSERTIONS
> b/tools/build/options/WITH_PTHREADS_ASSERTIONS
> new file mode 100644
> index 000000000000..03c15b76fb85
> --- /dev/null
> +++ b/tools/build/options/WITH_PTHREADS_ASSERTIONS
> @@ -0,0 +1 @@
> +Enable debugging assertions in pthreads library.
>
>

-- 
Nuno Teixeira
FreeBSD UNIX:  <eduardo@FreeBSD.org>   Web:  https://FreeBSD.org

[-- Attachment #2 --]
<div dir="ltr"><div>Hello Colin,</div><div><br></div><div>For people that turn off debug on main, should WITH_PTHREADS_ASSERTIONS be turned off? <br></div><div><br></div><div>e.g.</div><div>/etc/src.conf:</div><div>WITH_MALLOC_PRODUCTION=yes<br>WITHOUT_LLVM_ASSERTIONS=yes<br><br></div><div>Thanks,</div></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">Colin Percival &lt;<a href="mailto:cperciva@freebsd.org">cperciva@freebsd.org</a>&gt; escreveu (sexta, 5/09/2025 à(s) 22:36):<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The branch main has been updated by cperciva:<br>
<br>
URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=af60084978a43632c5ab2d6e3aca41be7a658d8c" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=af60084978a43632c5ab2d6e3aca41be7a658d8c</a><br>;
<br>
commit af60084978a43632c5ab2d6e3aca41be7a658d8c<br>
Author:     Colin Percival &lt;cperciva@FreeBSD.org&gt;<br>
AuthorDate: 2025-09-05 21:29:51 +0000<br>
Commit:     Colin Percival &lt;cperciva@FreeBSD.org&gt;<br>
CommitDate: 2025-09-05 21:35:53 +0000<br>
<br>
    Add description for WITH_PTHREADS_ASSERTIONS<br>
<br>
    This option is turned on by default in -CURRENT but will be turned off<br>
    in 15-STABLE; this description will land in the src.conf(5) man page<br>
    in that branch.<br>
<br>
    MFC after:      1 minute<br>
---<br>
 tools/build/options/WITH_PTHREADS_ASSERTIONS | 1 +<br>
 1 file changed, 1 insertion(+)<br>
<br>
diff --git a/tools/build/options/WITH_PTHREADS_ASSERTIONS b/tools/build/options/WITH_PTHREADS_ASSERTIONS<br>
new file mode 100644<br>
index 000000000000..03c15b76fb85<br>
--- /dev/null<br>
+++ b/tools/build/options/WITH_PTHREADS_ASSERTIONS<br>
@@ -0,0 +1 @@<br>
+Enable debugging assertions in pthreads library.<br>
<br>
</blockquote></div><div><br clear="all"></div><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><font color="#888888">Nuno Teixeira</font></div><div><div><font color="#888888">
FreeBSD UNIX:  &lt;eduardo@FreeBSD.org&gt;   Web:  <a href="https://FreeBSD.org" rel="noreferrer" target="_blank">https://FreeBSD.org</a><br></font></div></div></div></div>;

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UKymJ_3YefuHzO6ri=_GU44PcDZEQKSmGoMrmrBmxdttw>