Date: Sun, 21 Jun 2026 04:22:15 +0200 From: Oliver Pinter <oliver.pntr@gmail.com> To: Christos Margiolis <christos@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 730eaf466493 - main - sound tests: Add PROT_EXEC rejection test Message-ID: <CAPjTQNFkEADJzozLFPx=H31ZD42Opnx8KSpz3yg-Z80HHoC=Yg@mail.gmail.com> In-Reply-To: <6a36e480.318f5.79b60374@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sat, Jun 20, 2026 at 9:06 PM Christos Margiolis <christos@freebsd.org> wrote: > > The branch main has been updated by christos: > > URL: https://cgit.FreeBSD.org/src/commit/?id=730eaf466493315c1d1164eb6b59b14766f49322 > > commit 730eaf466493315c1d1164eb6b59b14766f49322 > Author: Christos Margiolis <christos@FreeBSD.org> > AuthorDate: 2026-06-12 06:20:26 +0000 > Commit: Christos Margiolis <christos@FreeBSD.org> > CommitDate: 2026-06-20 19:04:50 +0000 > > sound tests: Add PROT_EXEC rejection test > > Sponsored by: The FreeBSD Foundation > MFC after: 1 week > Reviewed by: markj, kib > Pull-Request: https://ron-dev.freebsd.org/FreeBSD/src/pulls/30 > --- > tests/sys/sound/mmap.c | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/tests/sys/sound/mmap.c b/tests/sys/sound/mmap.c > index b44b16e7f312..e83193db9bc1 100644 > --- a/tests/sys/sound/mmap.c > +++ b/tests/sys/sound/mmap.c > @@ -102,10 +102,38 @@ ATF_TC_BODY(mmap_buffer_lifetime, tc) > ATF_REQUIRE(munmap(buf, len) == 0); > } > > +ATF_TC(mmap_reject_prot_exec); > +ATF_TC_HEAD(mmap_reject_prot_exec, tc) > +{ > + atf_tc_set_md_var(tc, "descr", "mmap PROT_EXEC rejection test"); > + atf_tc_set_md_var(tc, "require.kmods", "snd_dummy"); > +} > + > +ATF_TC_BODY(mmap_reject_prot_exec, tc) > +{ > + uint8_t *buf; > + size_t len; > + int fd; > + > + fd = open("/dev/dsp.dummy", O_RDWR); > + ATF_REQUIRE_MSG(fd >= 0, FMT_ERR("open")); > + > + len = 8; > + > + buf = mmap(NULL, len, PROT_READ | *PROT_EXEC | PROT_EXEC*, MAP_SHARED, There is PROT_EXEC twice. > + fd, 0); > + ATF_REQUIRE_MSG(buf == MAP_FAILED, FMT_ERR("mmap")); > + > + munmap(buf, len); > + > + close(fd); > +} > + > ATF_TP_ADD_TCS(tp) > { > ATF_TP_ADD_TC(tp, mmap_offset_overflow); > ATF_TP_ADD_TC(tp, mmap_buffer_lifetime); > + ATF_TP_ADD_TC(tp, mmap_reject_prot_exec); > > return (atf_no_error()); > } > [-- Attachment #2 --] <div dir="ltr"><br><br>On Sat, Jun 20, 2026 at 9:06 PM Christos Margiolis <<a href="mailto:christos@freebsd.org">christos@freebsd.org</a>> wrote:<br>><br>> The branch main has been updated by christos:<br>><br>> URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=730eaf466493315c1d1164eb6b59b14766f49322">https://cgit.FreeBSD.org/src/commit/?id=730eaf466493315c1d1164eb6b59b14766f49322</a><br>><br>> commit 730eaf466493315c1d1164eb6b59b14766f49322<br>> Author: Christos Margiolis <christos@FreeBSD.org><br>> AuthorDate: 2026-06-12 06:20:26 +0000<br>> Commit: Christos Margiolis <christos@FreeBSD.org><br>> CommitDate: 2026-06-20 19:04:50 +0000<br>><br>> sound tests: Add PROT_EXEC rejection test<br>><br>> Sponsored by: The FreeBSD Foundation<br>> MFC after: 1 week<br>> Reviewed by: markj, kib<br>> Pull-Request: <a href="https://ron-dev.freebsd.org/FreeBSD/src/pulls/30">https://ron-dev.freebsd.org/FreeBSD/src/pulls/30</a><br>> ---<br>> tests/sys/sound/mmap.c | 28 ++++++++++++++++++++++++++++<br>> 1 file changed, 28 insertions(+)<br>><br>> diff --git a/tests/sys/sound/mmap.c b/tests/sys/sound/mmap.c<br>> index b44b16e7f312..e83193db9bc1 100644<br>> --- a/tests/sys/sound/mmap.c<br>> +++ b/tests/sys/sound/mmap.c<br>> @@ -102,10 +102,38 @@ ATF_TC_BODY(mmap_buffer_lifetime, tc)<br>> ATF_REQUIRE(munmap(buf, len) == 0);<br>> }<br>><br>> +ATF_TC(mmap_reject_prot_exec);<br>> +ATF_TC_HEAD(mmap_reject_prot_exec, tc)<br>> +{<br>> + atf_tc_set_md_var(tc, "descr", "mmap PROT_EXEC rejection test");<br>> + atf_tc_set_md_var(tc, "require.kmods", "snd_dummy");<br>> +}<br>> +<br>> +ATF_TC_BODY(mmap_reject_prot_exec, tc)<br>> +{<br>> + uint8_t *buf;<br>> + size_t len;<br>> + int fd;<br>> +<br>> + fd = open("/dev/dsp.dummy", O_RDWR);<br>> + ATF_REQUIRE_MSG(fd >= 0, FMT_ERR("open"));<br>> +<br>> + len = 8;<br>> +<br>> + buf = mmap(NULL, len, PROT_READ | <b>PROT_EXEC | PROT_EXEC</b>, MAP_SHARED,<div><br></div><div>There is PROT_EXEC twice.</div><div><br>> + fd, 0);<br>> + ATF_REQUIRE_MSG(buf == MAP_FAILED, FMT_ERR("mmap"));<br>> +<br>> + munmap(buf, len);<br>> +<br>> + close(fd);<br>> +}<br>> +<br>> ATF_TP_ADD_TCS(tp)<br>> {<br>> ATF_TP_ADD_TC(tp, mmap_offset_overflow);<br>> ATF_TP_ADD_TC(tp, mmap_buffer_lifetime);<br>> + ATF_TP_ADD_TC(tp, mmap_reject_prot_exec);<br>><br>> return (atf_no_error());<br>> }<br>><br></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPjTQNFkEADJzozLFPx=H31ZD42Opnx8KSpz3yg-Z80HHoC=Yg>